The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Brian Gerst <brgerst@gmail.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Ingo Molnar <mingo@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Brian Gerst <brgerst@gmail.com>
Subject: [PATCH v2 4/7] x86/syscall/x32: Move x32 syscall table
Date: Fri, 14 Mar 2025 11:12:17 -0400	[thread overview]
Message-ID: <20250314151220.862768-5-brgerst@gmail.com> (raw)
In-Reply-To: <20250314151220.862768-1-brgerst@gmail.com>

Since commit:

  2e958a8a510d ("x86/entry/x32: Rename __x32_compat_sys_* to
		 __x64_compat_sys_*"),

the ABI prefix for x32 syscalls is the same as native 64-bit
syscalls.  Move the x32 syscall table to syscall_64.c

No functional changes.

Signed-off-by: Brian Gerst <brgerst@gmail.com>
---
 arch/x86/entry/Makefile      |  1 -
 arch/x86/entry/syscall_64.c  | 13 +++++++++++++
 arch/x86/entry/syscall_x32.c | 25 -------------------------
 3 files changed, 13 insertions(+), 26 deletions(-)
 delete mode 100644 arch/x86/entry/syscall_x32.c

diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile
index 5fd28abfd5a0..e870f8aa936c 100644
--- a/arch/x86/entry/Makefile
+++ b/arch/x86/entry/Makefile
@@ -27,4 +27,3 @@ CFLAGS_REMOVE_entry_fred.o	+= -pg $(CC_FLAGS_FTRACE)
 obj-$(CONFIG_X86_FRED)		+= entry_64_fred.o entry_fred.o
 
 obj-$(CONFIG_IA32_EMULATION)	+= entry_64_compat.o syscall_32.o
-obj-$(CONFIG_X86_X32_ABI)	+= syscall_x32.o
diff --git a/arch/x86/entry/syscall_64.c b/arch/x86/entry/syscall_64.c
index e0c62d5a397c..a05f7be8a0e2 100644
--- a/arch/x86/entry/syscall_64.c
+++ b/arch/x86/entry/syscall_64.c
@@ -12,6 +12,9 @@
 #define __SYSCALL(nr, sym) extern long __x64_##sym(const struct pt_regs *);
 #define __SYSCALL_NORETURN(nr, sym) extern long __noreturn __x64_##sym(const struct pt_regs *);
 #include <asm/syscalls_64.h>
+#ifdef CONFIG_X86_X32_ABI
+#include <asm/syscalls_x32.h>
+#endif
 #undef  __SYSCALL
 
 #undef  __SYSCALL_NORETURN
@@ -37,6 +40,16 @@ long x64_sys_call(const struct pt_regs *regs, unsigned int nr)
 	}
 };
 
+#ifdef CONFIG_X86_X32_ABI
+long x32_sys_call(const struct pt_regs *regs, unsigned int nr)
+{
+	switch (nr) {
+	#include <asm/syscalls_x32.h>
+	default: return __x64_sys_ni_syscall(regs);
+	}
+};
+#endif
+
 static __always_inline bool do_syscall_x64(struct pt_regs *regs, int nr)
 {
 	/*
diff --git a/arch/x86/entry/syscall_x32.c b/arch/x86/entry/syscall_x32.c
deleted file mode 100644
index fb77908f44f3..000000000000
--- a/arch/x86/entry/syscall_x32.c
+++ /dev/null
@@ -1,25 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/* System call table for x32 ABI. */
-
-#include <linux/linkage.h>
-#include <linux/sys.h>
-#include <linux/cache.h>
-#include <linux/syscalls.h>
-#include <asm/syscall.h>
-
-#define __SYSCALL(nr, sym) extern long __x64_##sym(const struct pt_regs *);
-#define __SYSCALL_NORETURN(nr, sym) extern long __noreturn __x64_##sym(const struct pt_regs *);
-#include <asm/syscalls_x32.h>
-#undef  __SYSCALL
-
-#undef  __SYSCALL_NORETURN
-#define __SYSCALL_NORETURN __SYSCALL
-
-#define __SYSCALL(nr, sym) case nr: return __x64_##sym(regs);
-long x32_sys_call(const struct pt_regs *regs, unsigned int nr)
-{
-	switch (nr) {
-	#include <asm/syscalls_x32.h>
-	default: return __x64_sys_ni_syscall(regs);
-	}
-};
-- 
2.48.1


  parent reply	other threads:[~2025-03-14 15:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 15:12 [PATCH v2 0/7] x86/entry: Break up common.c Brian Gerst
2025-03-14 15:12 ` [PATCH v2 1/7] x86/xen: Move Xen upcall handler Brian Gerst
2025-03-14 15:16   ` Juergen Gross
2025-03-16 11:01   ` [tip: x86/cpu] " tip-bot2 for Brian Gerst
2025-03-19 11:03   ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-14 15:12 ` [PATCH v2 2/7] x86/syscall/32: Move 32-bit syscall dispatch code Brian Gerst
2025-03-16 11:01   ` [tip: x86/cpu] " tip-bot2 for Brian Gerst
2025-03-19 11:03   ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-14 15:12 ` [PATCH v2 3/7] x86/syscall/64: Move 64-bit " Brian Gerst
2025-03-16 11:01   ` [tip: x86/cpu] " tip-bot2 for Brian Gerst
2025-03-19 11:03   ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-14 15:12 ` Brian Gerst [this message]
2025-03-16 11:01   ` [tip: x86/cpu] x86/syscall/x32: Move x32 syscall table tip-bot2 for Brian Gerst
2025-03-19 11:03   ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-14 15:12 ` [PATCH v2 5/7] x86/syscall: Move sys_ni_syscall() Brian Gerst
2025-03-16 11:01   ` [tip: x86/cpu] " tip-bot2 for Brian Gerst
2025-03-19 11:03   ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-14 15:12 ` [PATCH v2 6/7] x86/syscall: Remove stray semicolons Brian Gerst
2025-03-16 11:01   ` [tip: x86/cpu] " tip-bot2 for Brian Gerst
2025-03-19 11:03   ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-14 15:12 ` [PATCH v2 7/7] x86/syscall/32: Add comment to conditional Brian Gerst
2025-03-14 17:19   ` Sohil Mehta
2025-03-14 17:43     ` Brian Gerst
2025-03-14 18:30       ` H. Peter Anvin
2025-03-16 11:01   ` [tip: x86/cpu] " tip-bot2 for Brian Gerst
2025-03-19 11:03   ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-14 17:22 ` [PATCH v2 0/7] x86/entry: Break up common.c Sohil Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250314151220.862768-5-brgerst@gmail.com \
    --to=brgerst@gmail.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox