Re: [PATCH v2 0/4] Improve soundness of bus device abstractions

Danilo Krummrich
2025-03-14T17:33:03Z

On Fri, Mar 14, 2025 at 10:28:09AM -0700, Boqun Feng wrote:
> On Fri, Mar 14, 2025 at 05:09:03PM +0100, Danilo Krummrich wrote:
> > Currently, when sharing references of bus devices (e.g. ARef<pci::Device>), we
> > do not have a way to restrict which functions of a bus device can be called.
> >
> > Consequently, it is possible to call all bus device functions concurrently from
> > any context. This includes functions, which access fields of the (bus) device,
> > which are not protected against concurrent access.
> >
> > This is improved by applying an execution context to the bus device in form of a
> > generic type.
> >
> > For instance, the PCI device reference that is passed to probe() has the type
> > pci::Device<Core>, which implements all functions that are only allowed to be
> > called from bus callbacks.
> >
> > The implementation for the default context (pci::Device) contains all functions
> > that are safe to call from any context concurrently.
> >
> > The context types can be extended as required, e.g. to limit availability of
> > certain (bus) device functions to probe().
> >
> > A branch containing the patches can be found in [1].
> >
> > [1] https://web.git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/log/?h=rust/device
> >
>
> Again,
>
> Acked-by: Boqun Feng <boqun.feng@gmail.com>

Sorry, I forgot to add your ACKs. Thanks for providing it again!