From: Jonathan Cameron <jic23@kernel.org>
To: Suraj Patil <surajpatil522@gmail.com>
Cc: lars@metafoo.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Suraj Patil <your-email@example.com>
Subject: Re: [PATCH] iio: industrialio-trigger: Fix typos in comments
Date: Sat, 15 Mar 2025 13:00:30 +0000 [thread overview]
Message-ID: <20250315130030.6db07f89@jic23-huawei> (raw)
In-Reply-To: <20250311155927.467523-1-surajpatil522@gmail.com>
On Tue, 11 Mar 2025 15:59:27 +0000
Suraj Patil <surajpatil522@gmail.com> wrote:
> Fixed multiple occurrences of 'reenable' to 're-enable' in comments.
>
> Signed-off-by: Suraj Patil <your-email@example.com>
> Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
Please carefully read what your changes are before sending!
This obviously breaks the code.
Also don't take a code spell checker to literally.
reenable is fine here.
> ---
> drivers/iio/industrialio-trigger.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> index 54416a384232..21688cd348c6 100644
> --- a/drivers/iio/industrialio-trigger.c
> +++ b/drivers/iio/industrialio-trigger.c
> @@ -162,11 +162,11 @@ static void iio_reenable_work_fn(struct work_struct *work)
> * This 'might' occur after the trigger state is set to disabled -
> * in that case the driver should skip reenabling.
> */
> - trig->ops->reenable(trig);
> + trig->ops->re-enable(trig);
> }
>
> /*
> - * In general, reenable callbacks may need to sleep and this path is
> + * In general, re-enable callbacks may need to sleep and this path is
> * not performance sensitive, so just queue up a work item
> * to reneable the trigger for us.
> *
> @@ -175,14 +175,14 @@ static void iio_reenable_work_fn(struct work_struct *work)
> * the final decrement is still in this interrupt.
> * 2) The trigger has been removed, but one last interrupt gets through.
> *
> - * For (1) we must call reenable, but not in atomic context.
> + * For (1) we must call re-enable, but not in atomic context.
> * For (2) it should be safe to call reenanble, if drivers never blindly
> - * reenable after state is off.
> + * re-enable after state is off.
> */
> static void iio_trigger_notify_done_atomic(struct iio_trigger *trig)
> {
> if (atomic_dec_and_test(&trig->use_count) && trig->ops &&
> - trig->ops->reenable)
> + trig->ops->re-enable)
> schedule_work(&trig->reenable_work);
> }
>
> @@ -243,8 +243,8 @@ EXPORT_SYMBOL(iio_trigger_poll_nested);
> void iio_trigger_notify_done(struct iio_trigger *trig)
> {
> if (atomic_dec_and_test(&trig->use_count) && trig->ops &&
> - trig->ops->reenable)
> - trig->ops->reenable(trig);
> + trig->ops->re-enable)
> + trig->ops->re-enable(trig);
> }
> EXPORT_SYMBOL(iio_trigger_notify_done);
>
prev parent reply other threads:[~2025-03-15 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 15:59 [PATCH] iio: industrialio-trigger: Fix typos in comments Suraj Patil
2025-03-13 0:51 ` kernel test robot
2025-03-13 1:53 ` kernel test robot
2025-03-15 13:00 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250315130030.6db07f89@jic23-huawei \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=surajpatil522@gmail.com \
--cc=your-email@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox