From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D1C98F5C for ; Mon, 17 Mar 2025 07:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742197812; cv=none; b=XcZmRk2qCQObRYtOUDIFVcCK2iEQt8qy3SLm98Rqrtd+fYsYnZJePvYoWqB4/pGz0PHhJulQhSWoHfHs+KLemYUt6SSgTPrzeVtD8Zt0+HQ5ITyP3Vm+q6xGJgLD6k7msFzUQ4e2Jzw5dZ4RTFBAFGqaJ89A97lui5S+nFttCRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742197812; c=relaxed/simple; bh=KVWI39d3HW9xN1/QXc38Yamt5ZjCW0vGygfdTOdFOvY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f8fzBtkcAJnMPohOcSNaR7gFnFGAfIHzT1KLhie2cW3DF0gj2zoG4eBC/D2wCQkKMFyA/RgV2NLszN8JEmfDDkNufS1IJOLSZnAxOL6F/9IO9pN+xEB23FP56yMEEFB9tsZz8uoPQUaI+W3knrmgNaaZRbALeEqc78x5gypZl8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=VrDD1GPa; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="VrDD1GPa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1742197808; bh=KVWI39d3HW9xN1/QXc38Yamt5ZjCW0vGygfdTOdFOvY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VrDD1GPaC7hF8wlKN0592XCetB1p4pBnbRnhKq0eoxITBOlDTHs7jbZ1kCUUGH+9d 7hs6IN6w9+mnFy2VbvtQiimZNuvm9X702ogS6xy2wOUaAmWjDtf/7zqmTOIUgERnEw abJQGGt0yf9vRhLYL6GTchZmDLfNEaQY+Ej93WuPpvmRin45NzrMI2Wrp5DD0kOWgK lGkROCxOC2ju1jkeiPPG5qVrwUBUet6cBWzc0flIsJswfDZMAFZk4JB5auDNGxbp9t 8NV1im/+X/89nnHBpSxu/MCuSz3SvtaR6F9JnoNVO/I+HgVaeHAVQpnX2Q3+YLkIos 9niI6cWBuXNaw== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 0252B17E0B25; Mon, 17 Mar 2025 08:50:07 +0100 (CET) Date: Mon, 17 Mar 2025 08:50:02 +0100 From: Boris Brezillon To: =?UTF-8?B?QWRyacOhbg==?= Larumbe Cc: Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] drm/panthor: Add driver IOCTL for setting BO labels Message-ID: <20250317085002.304305cf@collabora.com> In-Reply-To: <20250316215139.3940623-3-adrian.larumbe@collabora.com> References: <20250316215139.3940623-1-adrian.larumbe@collabora.com> <20250316215139.3940623-3-adrian.larumbe@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 16 Mar 2025 21:51:33 +0000 Adri=C3=A1n Larumbe wrote: > Allow UM to label a BO for which it possesses a DRM handle. >=20 > Signed-off-by: Adri=C3=A1n Larumbe > --- > drivers/gpu/drm/panthor/panthor_drv.c | 31 +++++++++++++++++++++++++++ > include/uapi/drm/panthor_drm.h | 14 ++++++++++++ > 2 files changed, 45 insertions(+) >=20 > diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/pant= hor/panthor_drv.c > index 310bb44abe1a..f41b8946258f 100644 > --- a/drivers/gpu/drm/panthor/panthor_drv.c > +++ b/drivers/gpu/drm/panthor/panthor_drv.c > @@ -1330,6 +1330,35 @@ static int panthor_ioctl_vm_get_state(struct drm_d= evice *ddev, void *data, > return 0; > } > =20 > +static int panthor_ioctl_label_bo(struct drm_device *ddev, void *data, > + struct drm_file *file) > +{ > + struct drm_panthor_label_bo *args =3D data; > + struct drm_gem_object *obj; > + const char *label; > + int ret =3D 0; > + > + obj =3D drm_gem_object_lookup(file, args->handle); > + if (!obj) > + return -ENOENT; > + > + if (args->len && args->label) { > + label =3D strndup_user(u64_to_user_ptr(args->label), args->len + 1); > + if (IS_ERR(label)) { > + ret =3D PTR_ERR(label); > + goto err_label; > + } > + } else > + label =3D NULL; > + > + panthor_gem_label_bo(obj, label); > + > +err_label: > + drm_gem_object_put(obj); > + > + return ret; > +} > + > static int > panthor_open(struct drm_device *ddev, struct drm_file *file) > { > @@ -1399,6 +1428,7 @@ static const struct drm_ioctl_desc panthor_drm_driv= er_ioctls[] =3D { > PANTHOR_IOCTL(TILER_HEAP_CREATE, tiler_heap_create, DRM_RENDER_ALLOW), > PANTHOR_IOCTL(TILER_HEAP_DESTROY, tiler_heap_destroy, DRM_RENDER_ALLOW), > PANTHOR_IOCTL(GROUP_SUBMIT, group_submit, DRM_RENDER_ALLOW), > + PANTHOR_IOCTL(LABEL_BO, label_bo, DRM_RENDER_ALLOW), > }; > =20 > static int panthor_mmap(struct file *filp, struct vm_area_struct *vma) > @@ -1508,6 +1538,7 @@ static void panthor_debugfs_init(struct drm_minor *= minor) > * - 1.2 - adds DEV_QUERY_GROUP_PRIORITIES_INFO query > * - adds PANTHOR_GROUP_PRIORITY_REALTIME priority > * - 1.3 - adds DRM_PANTHOR_GROUP_STATE_INNOCENT flag > + * - 1.4 - adds DRM_IOCTL_PANTHOR_LABEL_BO ioctl > */ > static const struct drm_driver panthor_drm_driver =3D { > .driver_features =3D DRIVER_RENDER | DRIVER_GEM | DRIVER_SYNCOBJ | > diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_dr= m.h > index 97e2c4510e69..1a7ed567d36a 100644 > --- a/include/uapi/drm/panthor_drm.h > +++ b/include/uapi/drm/panthor_drm.h > @@ -127,6 +127,9 @@ enum drm_panthor_ioctl_id { > =20 > /** @DRM_PANTHOR_TILER_HEAP_DESTROY: Destroy a tiler heap. */ > DRM_PANTHOR_TILER_HEAP_DESTROY, > + > + /** @DRM_PANTHOR_LABEL_BO: Label a BO. */ > + DRM_PANTHOR_LABEL_BO, DRM_PANTHOR_BO_SET_LABEL to follow the DRM_PANTHOR__ naming scheme used in this file. I'd also be tempted to introduce a DRM_PANTHOR_BO_GET_LABEL ioctl while we're at it. > }; > =20 > /** > @@ -977,6 +980,15 @@ struct drm_panthor_tiler_heap_destroy { > __u32 pad; > }; > =20 > +/** > + * struct drm_panthor_label_bo - Arguments passed to DRM_IOCTL_PANTHOR_L= ABEL_BO > + */ > +struct drm_panthor_label_bo { > + __u32 handle; > + __u32 len; > + __u64 label; Can you document these fields? > +}; > + > /** > * DRM_IOCTL_PANTHOR() - Build a Panthor IOCTL number > * @__access: Access type. Must be R, W or RW. > @@ -1019,6 +1031,8 @@ enum { > DRM_IOCTL_PANTHOR(WR, TILER_HEAP_CREATE, tiler_heap_create), > DRM_IOCTL_PANTHOR_TILER_HEAP_DESTROY =3D > DRM_IOCTL_PANTHOR(WR, TILER_HEAP_DESTROY, tiler_heap_destroy), > + DRM_IOCTL_PANTHOR_LABEL_BO =3D > + DRM_IOCTL_PANTHOR(WR, LABEL_BO, label_bo), > }; > =20 > #if defined(__cplusplus)