From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Li Ming <ming.li@zohomail.com>, Arnd Bergmann <arnd@arndb.de>,
Robert Richter <rrichter@amd.com>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxl: fix FWCTL dependency
Date: Mon, 17 Mar 2025 14:42:52 -0300 [thread overview]
Message-ID: <20250317174252.GA10600@ziepe.ca> (raw)
In-Reply-To: <0c2a1f2f-539f-4a94-82f4-57406421a3b8@intel.com>
On Mon, Mar 10, 2025 at 08:24:44AM -0700, Dave Jiang wrote:
>
>
> On 3/10/25 6:51 AM, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The 'FWCTL' subsystem is selected by CXL_FEATURES, which is a 'bool' symbol
> > with a dependency on CXL_PCI, but referenced by the cxl_core.ko.
> > When cxl_core is built-in, but the cxl_pci.ko driver is a loadable mdoule,
> > this results in a link failure:
> >
> > ld.lld-21: error: undefined symbol: _fwctl_alloc_device
> >>>> referenced by features.c:695 (/home/arnd/arm-soc/drivers/cxl/core/features.c:695)
> > ld.lld-21: error: undefined symbol: fwctl_register
> >>>> referenced by features.c:699 (/home/arnd/arm-soc/drivers/cxl/core/features.c:699)
> > ld.lld-21: error: undefined symbol: fwctl_unregister
> >>>> referenced by features.c:676 (/home/arnd/arm-soc/drivers/cxl/core/features.c:676)
> >
> > Move the 'select' into the symbol that controls the core module instead.
> >
> > Fixes: a53a6004e7a5 ("cxl: Add FWCTL support to CXL")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Acked-by: Dave Jiang <dave.jiang@intel.com>
>
> Thanks for the fix Arnd. Jason can you please append this fix to your latest branch? Thanks!
I folded it into the Fixes commit thanks
Jason
next prev parent reply other threads:[~2025-03-17 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 13:51 [PATCH] cxl: fix FWCTL dependency Arnd Bergmann
2025-03-10 15:24 ` Dave Jiang
2025-03-17 17:42 ` Jason Gunthorpe [this message]
2025-03-10 18:27 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250317174252.GA10600@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alison.schofield@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ming.li@zohomail.com \
--cc=rppt@kernel.org \
--cc=rrichter@amd.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox