Re: [PATCH v4 2/3] iommufd: Move iommufd_sw_msi and related functions to driver.c

[Jason Gunthorpe <jgg@nvidia.com>]

On Thu, Mar 06, 2025 at 01:00:48PM -0800, Nicolin Chen wrote:
> To provide the iommufd_sw_msi() to the iommu core that is under a different
> Kconfig, move it and its related functions to driver.c. Then, stub it into
> the iommu-priv header. The iommufd_sw_msi_install() continues to be used by
> iommufd internal, so put it in the private header.
> 
> Since this affects the module size, here is before-n-after size comparison:
> [Before]
>    text	   data	    bss	    dec	    hex	filename
>   18797	    848	     56	  19701	   4cf5	drivers/iommu/iommufd/device.o
>     722	     44	      0	    766	    2fe	drivers/iommu/iommufd/driver.o
> [After]
>    text	   data	    bss	    dec	    hex	filename
>   17671	    808	     56	  18535	   4867	drivers/iommu/iommufd/device.o
>    1900	    100	      0	   2000	    7d0	drivers/iommu/iommufd/driver.o
> 
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/iommu/iommu-priv.h              |  13 +++
>  drivers/iommu/iommufd/iommufd_private.h |   7 +-
>  drivers/iommu/iommufd/device.c          | 131 ++----------------------
>  drivers/iommu/iommufd/driver.c          | 125 ++++++++++++++++++++++
>  4 files changed, 151 insertions(+), 125 deletions(-)

+1K is more than I would have liked, but OK

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason