The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Daniel Vacek <neelx@suse.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove EXTENT_BUFFER_IN_TREE flag
Date: Tue, 18 Mar 2025 16:45:52 +0100	[thread overview]
Message-ID: <20250318154552.GE32661@twin.jikos.cz> (raw)
In-Reply-To: <20250318095440.436685-1-neelx@suse.com>

On Tue, Mar 18, 2025 at 10:54:38AM +0100, Daniel Vacek wrote:
> This flag is set after inserting the eb to the buffer tree and cleared on
> it's removal. But it does not bring any added value. Just kill it for good.

Would be good to add the reference to commit that added the bit,
34b41acec1ccc0 ("Btrfs: use a bit to track if we're in the radix tree")
and wanted to make use of it, faa2dbf004e89e ("Btrfs: add sanity tests
for new qgroup accounting code"). And both are 10+ years old.

> Signed-off-by: Daniel Vacek <neelx@suse.com>

Reviewed-by: David Sterba <dsterba@suse.com>

  reply	other threads:[~2025-03-18 15:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18  9:54 [PATCH] btrfs: remove EXTENT_BUFFER_IN_TREE flag Daniel Vacek
2025-03-18 15:45 ` David Sterba [this message]
2025-03-18 17:07   ` Daniel Vacek
2025-03-18 17:16     ` David Sterba
2025-03-18 16:00 ` David Sterba
2025-03-18 16:04   ` David Sterba
2025-03-18 17:08     ` Daniel Vacek
2025-03-27 18:01 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250318154552.GE32661@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neelx@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox