Re: [PATCH v5 08/11] gpio: max7360: Add MAX7360 gpio support

Andy Shevchenko
2025-03-25T15:57:11Z

On Tue, Mar 25, 2025 at 03:46:20PM +0100, Mathieu Dubois-Briand wrote:
> On Wed Mar 19, 2025 at 12:50 PM CET, Andy Shevchenko wrote:
> > On Tue, Mar 18, 2025 at 05:26:24PM +0100, Mathieu Dubois-Briand wrote:

...

> > > + /*
> > > + * Port GPIOs with interrupt-controller property: add IRQ
> > > + * controller.
> > > + */
> > > + gpio_config.regmap_irq_flags = IRQF_TRIGGER_LOW | IRQF_ONESHOT | IRQF_SHARED;
> >
> > But why is this being overridden? The DT or another firmware description has to
> > provide the correct settings, no?
>
> Ok, thinking about it, yes, IRQF_TRIGGER_LOW shoud come from firmware
> description. But IRQF_ONESHOT and IRQF_SHARED should still come from
> here, no?

This is my view as well.

--
With Best Regards,
Andy Shevchenko