Re: [PATCH v5 06/11] gpio: regmap: Allow to allocate regmap-irq device

Andy Shevchenko
2025-03-20T10:50:55Z

On Thu, Mar 20, 2025 at 08:55:57AM +0100, Mathieu Dubois-Briand wrote:
> On Tue Mar 18, 2025 at 5:52 PM CET, Andy Shevchenko wrote:
> > On Tue, Mar 18, 2025 at 05:26:22PM +0100, Mathieu Dubois-Briand wrote:

...

> > > +#ifdef CONFIG_GPIOLIB_IRQCHIP
> > > + struct regmap_irq_chip *regmap_irq_chip;
> > > + struct regmap_irq_chip_data **regmap_irq_chip_data;
> >
> > But why double pointer?
>
> I believe this has to be a double pointer, as it is going to be assigned
> a pointer value: data buffer is allocated inside of
> devm_regmap_add_irq_chip_fwnode().

Yes, but it doesn't need to be a double one in the data structrure, right?

> But as you said, it's better to remove it and add it later if there is
> an use case.

This would be even better for now, thanks!

--
With Best Regards,
Andy Shevchenko