Re: [PATCH v5 08/11] gpio: max7360: Add MAX7360 gpio support

kernel test robot
2025-03-19T14:13:56Z

Hi Mathieu,

kernel test robot noticed the following build errors:

[auto build test ERROR on a64dcfb451e254085a7daee5fe51bf22959d52d3]

url: https://github.com/intel-lab-lkp/linux/commits/Mathieu-Dubois-Briand/dt-bindings-mfd-gpio-Add-MAX7360/20250319-003750
base: a64dcfb451e254085a7daee5fe51bf22959d52d3
patch link: https://lore.kernel.org/r/20250318-mdb-max7360-support-v5-8-fb20baf97da0%40bootlin.com
patch subject: [PATCH v5 08/11] gpio: max7360: Add MAX7360 gpio support
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20250319/202503192257.KfRkL589-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250319/202503192257.KfRkL589-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503192257.KfRkL589-lkp@intel.com/

All errors (new ones prefixed by >>):

drivers/gpio/gpio-max7360.c: In function 'max7360_set_gpos_count':
>> drivers/gpio/gpio-max7360.c:78:8: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
val = FIELD_PREP(MAX7360_PORTS, available_gpios);
^~~~~~~~~~
cc1: some warnings being treated as errors

vim +/FIELD_PREP +78 drivers/gpio/gpio-max7360.c

55
56 static int max7360_set_gpos_count(struct device *dev, struct regmap *regmap)
57 {
58 /*
59 * MAX7360 COL0 to COL7 pins can be used either as keypad columns,
60 * general purpose output or a mix of both.
61 * By default, all pins are used as keypad, here we update this
62 * configuration to allow to use some of them as GPIOs.
63 */
64 unsigned int available_gpios;
65 unsigned int val;
66 int ret;
67
68 ret = max7360_get_available_gpos(dev, &available_gpios);
69 if (ret)
70 return ret;
71
72 /*
73 * Configure which GPIOs will be used for keypad.
74 * MAX7360_REG_DEBOUNCE contains configuration both for keypad debounce
75 * timings and gpos/keypad columns repartition. Only the later is
76 * modified here.
77 */
> 78 val = FIELD_PREP(MAX7360_PORTS, available_gpios);
79 ret = regmap_write_bits(regmap, MAX7360_REG_DEBOUNCE, MAX7360_PORTS, val);
80 if (ret) {
81 dev_err(dev, "Failed to write max7360 columns/gpos configuration");
82 return ret;
83 }
84
85 return 0;
86 }
87

--
0-DAY CI Kernel Test Service