Re: [PATCH v5 08/11] gpio: max7360: Add MAX7360 gpio support

Mathieu Dubois-Briand
2025-03-25T14:46:28Z

On Wed Mar 19, 2025 at 12:50 PM CET, Andy Shevchenko wrote:
> On Tue, Mar 18, 2025 at 05:26:24PM +0100, Mathieu Dubois-Briand wrote:
> > Add driver for Maxim Integrated MAX7360 GPIO/GPO controller.
> >
> > Two sets of GPIOs are provided by the device:
> > - Up to 8 GPIOs, shared with the PWM and rotary encoder functionalities.
> > These GPIOs also provide interrupts on input changes.
> > - Up to 6 GPOs, on unused keypad columns pins.
>
> ...
>
> > + /*
> > + * Port GPIOs with interrupt-controller property: add IRQ
> > + * controller.
> > + */
> > + gpio_config.regmap_irq_flags = IRQF_TRIGGER_LOW | IRQF_ONESHOT | IRQF_SHARED;
>
> But why is this being overridden? The DT or another firmware description has to
> provide the correct settings, no?
>

Ok, thinking about it, yes, IRQF_TRIGGER_LOW shoud come from firmware
description. But IRQF_ONESHOT and IRQF_SHARED should still come from
here, no?

I'm OK with all other points.

Thanks for your review!
Mathieu

--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering