Re: [PATCH v5 09/11] input: keyboard: Add support for MAX7360 keypad

Mathieu Dubois-Briand
2025-03-25T14:57:04Z

On Wed Mar 19, 2025 at 1:02 PM CET, Andy Shevchenko wrote:
> On Tue, Mar 18, 2025 at 05:26:25PM +0100, Mathieu Dubois-Briand wrote:
> > Add driver for Maxim Integrated MAX7360 keypad controller, providing
> > support for up to 64 keys, with a matrix of 8 columns and 8 rows.
>
> ...
>
> > + help
> > + If you say yes here you get support for the keypad controller on the
> > + Maxim MAX7360 I/O Expander.
> > +
> > + To compile this driver as a module, choose M here: the
> > + module will be called max7360_keypad.
>
> One paragraph is wrapped way too late or too early, can you make them approx.
> the same in terms of a line width?
>

Thanks. I had a look at all other Kconfigs, I believe they are all fixed
now.

> > +
> > + input_set_capability(input, EV_MSC, MSC_SCAN);
> > + if (autorepeat)
> > + __set_bit(EV_REP, input->evbit);
> > +
> > + input_set_drvdata(input, max7360_keypad);
> > +
> > + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, max7360_keypad_irq,
> > + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
>
> What's wrong with the interrupt flags provided by firmware description?
>

So same question as for the GPIO driver: IRQF_TRIGGER_LOW from the
firmware, but IRQF_ONESHOT from the driver? Or should everything come
from the firmware?

Thanks again for your review.
Mathieu

--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering