public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
	Sebastian Reichel <sre@kernel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: oe-kbuild-all@lists.linux.dev,
	"Oleksij Rempel" <o.rempel@pengutronix.de>,
	"Mark Brown" <broonie@kernel.org>,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Lukasz Luba" <lukasz.luba@arm.com>,
	linux-pm@vger.kernel.org, "Søren Andersen" <san@skov.dk>
Subject: Re: [PATCH v5 6/7] regulator: set Power State Change Reason before hw_protection_shutdown()
Date: Tue, 18 Mar 2025 20:36:20 +0800	[thread overview]
Message-ID: <202503182046.kOuLXxTn-lkp@intel.com> (raw)
In-Reply-To: <20250310103732.423542-7-o.rempel@pengutronix.de>

Hi Oleksij,

kernel test robot noticed the following build errors:

[auto build test ERROR on sre-power-supply/for-next]
[also build test ERROR on broonie-regulator/for-next rafael-pm/thermal linus/master v6.14-rc7]
[cannot apply to next-20250317]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Oleksij-Rempel/power-Extend-power_on_reason-h-for-upcoming-PSCRR-framework/20250310-184319
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
patch link:    https://lore.kernel.org/r/20250310103732.423542-7-o.rempel%40pengutronix.de
patch subject: [PATCH v5 6/7] regulator: set Power State Change Reason before hw_protection_shutdown()
config: m68k-randconfig-r073-20250314 (https://download.01.org/0day-ci/archive/20250318/202503182046.kOuLXxTn-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250318/202503182046.kOuLXxTn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503182046.kOuLXxTn-lkp@intel.com/

All errors (new ones prefixed by >>):

   m68k-linux-ld: drivers/regulator/core.o: in function `regulator_handle_critical':
>> drivers/regulator/core.c:5270:(.text+0x20c6): undefined reference to `set_power_state_change_reason'


vim +5270 drivers/regulator/core.c

  5234	
  5235	/**
  5236	 * regulator_handle_critical - Handle events for system-critical regulators.
  5237	 * @rdev: The regulator device.
  5238	 * @event: The event being handled.
  5239	 *
  5240	 * This function handles critical events such as under-voltage, over-current,
  5241	 * and unknown errors for regulators deemed system-critical. On detecting such
  5242	 * events, it triggers a hardware protection shutdown with a defined timeout.
  5243	 */
  5244	static void regulator_handle_critical(struct regulator_dev *rdev,
  5245					      unsigned long event)
  5246	{
  5247		enum pscr_reason pscr;
  5248		const char *reason = NULL;
  5249	
  5250		if (!rdev->constraints->system_critical)
  5251			return;
  5252	
  5253		switch (event) {
  5254		case REGULATOR_EVENT_UNDER_VOLTAGE:
  5255			reason = "System critical regulator: voltage drop detected";
  5256			pscr = PSCR_UNDER_VOLTAGE;
  5257			break;
  5258		case REGULATOR_EVENT_OVER_CURRENT:
  5259			reason = "System critical regulator: over-current detected";
  5260			pscr = PSCR_OVER_CURRENT;
  5261			break;
  5262		case REGULATOR_EVENT_FAIL:
  5263			reason = "System critical regulator: unknown error";
  5264			pscr = PSCR_REGULATOR_FAILURE;
  5265		}
  5266	
  5267		if (!reason)
  5268			return;
  5269	
> 5270		set_power_state_change_reason(pscr);
  5271		hw_protection_shutdown(reason,
  5272				       rdev->constraints->uv_less_critical_window_ms);
  5273	}
  5274	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2025-03-18 12:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10 10:37 [PATCH v5 0/7] Introduction of PSCR Framework and Related Components Oleksij Rempel
2025-03-10 10:37 ` [PATCH v5 1/7] power: Extend power_on_reason.h for upcoming PSCRR framework Oleksij Rempel
2025-03-10 10:37 ` [PATCH v5 2/7] power: reset: Introduce PSCR Recording Framework for Non-Volatile Storage Oleksij Rempel
2025-03-10 10:37 ` [PATCH v5 3/7] nvmem: provide consumer access to cell size metrics Oleksij Rempel
2025-03-10 10:37 ` [PATCH v5 4/7] nvmem: add support for device and sysfs-based cell lookups Oleksij Rempel
2025-03-10 10:37 ` [PATCH v5 5/7] power: reset: add PSCR NVMEM Driver for Recording Power State Change Reasons Oleksij Rempel
2025-03-10 10:37 ` [PATCH v5 6/7] regulator: set Power State Change Reason before hw_protection_shutdown() Oleksij Rempel
2025-03-14 10:26   ` kernel test robot
2025-03-18 12:36   ` kernel test robot [this message]
2025-03-10 10:37 ` [PATCH v5 7/7] thermal: core: Record PSCR " Oleksij Rempel
2025-03-18 19:33   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202503182046.kOuLXxTn-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=broonie@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=kernel@pengutronix.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=o.rempel@pengutronix.de \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=san@skov.dk \
    --cc=sre@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox