From: Lance Yang <ioworker0@gmail.com>
To: akpm@linux-foundation.org
Cc: will@kernel.org, peterz@infradead.org, mingo@redhat.com,
longman@redhat.com, mhiramat@kernel.org,
anna.schumaker@oracle.com, boqun.feng@gmail.com,
joel.granados@kernel.org, kent.overstreet@linux.dev,
leonylgao@tencent.com, linux-kernel@vger.kernel.org,
rostedt@goodmis.org, senozhatsky@chromium.org,
tfiga@chromium.org, amaindex@outlook.com, jstultz@google.com,
Lance Yang <ioworker0@gmail.com>
Subject: [PATCH v3 0/3] hung_task: extend blocking task stacktrace dump to semaphore
Date: Wed, 19 Mar 2025 16:11:35 +0800 [thread overview]
Message-ID: <20250319081138.25133-1-ioworker0@gmail.com> (raw)
Hi all,
Inspired by mutex blocker tracking[1], this patch series extend the
feature to not only dump the blocker task holding a mutex but also to
support semaphores. Unlike mutexes, semaphores lack explicit ownership
tracking, making it challenging to identify the root cause of hangs. To
address this, we introduce a last_holder field to the semaphore structure,
which is updated when a task successfully calls down() and cleared during
up().
The assumption is that if a task is blocked on a semaphore, the holders
must not have released it. While this does not guarantee that the last
holder is one of the current blockers, it likely provides a practical hint
for diagnosing semaphore-related stalls.
With this change, the hung task detector can now show blocker task's info
like below:
[Thu Mar 13 15:18:38 2025] INFO: task cat:1803 blocked for more than 122 seconds.
[Thu Mar 13 15:18:38 2025] Tainted: G OE 6.14.0-rc3+ #14
[Thu Mar 13 15:18:38 2025] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[Thu Mar 13 15:18:38 2025] task:cat state:D stack:0 pid:1803 tgid:1803 ppid:1057 task_flags:0x400000 flags:0x00000004
[Thu Mar 13 15:18:38 2025] Call trace:
[Thu Mar 13 15:18:38 2025] __switch_to+0x1ec/0x380 (T)
[Thu Mar 13 15:18:38 2025] __schedule+0xc30/0x44f8
[Thu Mar 13 15:18:38 2025] schedule+0xb8/0x3b0
[Thu Mar 13 15:18:38 2025] schedule_timeout+0x1d0/0x208
[Thu Mar 13 15:18:38 2025] __down_common+0x2d4/0x6f8
[Thu Mar 13 15:18:38 2025] __down+0x24/0x50
[Thu Mar 13 15:18:38 2025] down+0xd0/0x140
[Thu Mar 13 15:18:38 2025] read_dummy+0x3c/0xa0 [hung_task_sem]
[Thu Mar 13 15:18:38 2025] full_proxy_read+0xfc/0x1d0
[Thu Mar 13 15:18:38 2025] vfs_read+0x1a0/0x858
[Thu Mar 13 15:18:38 2025] ksys_read+0x100/0x220
[Thu Mar 13 15:18:38 2025] __arm64_sys_read+0x78/0xc8
[Thu Mar 13 15:18:38 2025] invoke_syscall+0xd8/0x278
[Thu Mar 13 15:18:38 2025] el0_svc_common.constprop.0+0xb8/0x298
[Thu Mar 13 15:18:38 2025] do_el0_svc+0x4c/0x88
[Thu Mar 13 15:18:38 2025] el0_svc+0x44/0x108
[Thu Mar 13 15:18:38 2025] el0t_64_sync_handler+0x134/0x160
[Thu Mar 13 15:18:38 2025] el0t_64_sync+0x1b8/0x1c0
[Thu Mar 13 15:18:38 2025] INFO: task cat:1803 blocked on a semaphore likely last held by task cat:1802
[Thu Mar 13 15:18:38 2025] task:cat state:S stack:0 pid:1802 tgid:1802 ppid:1057 task_flags:0x400000 flags:0x00000004
[Thu Mar 13 15:18:38 2025] Call trace:
[Thu Mar 13 15:18:38 2025] __switch_to+0x1ec/0x380 (T)
[Thu Mar 13 15:18:38 2025] __schedule+0xc30/0x44f8
[Thu Mar 13 15:18:38 2025] schedule+0xb8/0x3b0
[Thu Mar 13 15:18:38 2025] schedule_timeout+0xf4/0x208
[Thu Mar 13 15:18:38 2025] msleep_interruptible+0x70/0x130
[Thu Mar 13 15:18:38 2025] read_dummy+0x48/0xa0 [hung_task_sem]
[Thu Mar 13 15:18:38 2025] full_proxy_read+0xfc/0x1d0
[Thu Mar 13 15:18:38 2025] vfs_read+0x1a0/0x858
[Thu Mar 13 15:18:38 2025] ksys_read+0x100/0x220
[Thu Mar 13 15:18:38 2025] __arm64_sys_read+0x78/0xc8
[Thu Mar 13 15:18:38 2025] invoke_syscall+0xd8/0x278
[Thu Mar 13 15:18:38 2025] el0_svc_common.constprop.0+0xb8/0x298
[Thu Mar 13 15:18:38 2025] do_el0_svc+0x4c/0x88
[Thu Mar 13 15:18:38 2025] el0_svc+0x44/0x108
[Thu Mar 13 15:18:38 2025] el0t_64_sync_handler+0x134/0x160
[Thu Mar 13 15:18:38 2025] el0t_64_sync+0x1b8/0x1c0
[1] https://lore.kernel.org/all/174046694331.2194069.15472952050240807469.stgit@mhiramat.tok.corp.google.com
Thanks,
Lance
---
v2 -> v3:
* Remove the unnecessary WARN_ON_ONCE check for 'current->blocker',
suggested by Masami
* Drop the redundant #ifdef for including the hung task header file,
suggested by Masam
* Unify the samples into 'hung_task_tests.c', suggested by Masami
* https://lore.kernel.org/all/20250314144300.32542-1-ioworker0@gmail.com
v1 -> v2:
* Use one field to store the blocker as only one is active at a time,
suggested by Masami
* Leverage the LSB of the blocker field to reduce memory footprint,
suggested by Masami
* Add a hung_task detector semaphore blocking test sample code
* https://lore.kernel.org/all/20250301055102.88746-1-ioworker0@gmail.com
Lance Yang (2):
hung_task: replace blocker_mutex with encoded blocker
hung_task: show the blocker task if the task is hung on semaphore
Zi Li (1):
samples: extend hung_task detector test with semaphore support
include/linux/hung_task.h | 93 +++++++++++++++++++++++++++
include/linux/sched.h | 2 +-
include/linux/semaphore.h | 15 ++++-
kernel/hung_task.c | 49 +++++++++++----
kernel/locking/mutex.c | 5 +-
kernel/locking/semaphore.c | 52 ++++++++++++++--
samples/Kconfig | 9 +--
samples/hung_task/Makefile | 2 +-
samples/hung_task/hung_task_mutex.c | 66 --------------------
samples/hung_task/hung_task_tests.c | 97 +++++++++++++++++++++++++++++
10 files changed, 298 insertions(+), 92 deletions(-)
create mode 100644 include/linux/hung_task.h
delete mode 100644 samples/hung_task/hung_task_mutex.c
create mode 100644 samples/hung_task/hung_task_tests.c
--
2.45.2
next reply other threads:[~2025-03-19 8:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 8:11 Lance Yang [this message]
2025-03-19 8:11 ` [PATCH v3 1/3] hung_task: replace blocker_mutex with encoded blocker Lance Yang
2025-03-19 13:51 ` Masami Hiramatsu
2025-03-19 8:11 ` [PATCH v3 2/3] hung_task: show the blocker task if the task is hung on semaphore Lance Yang
2025-03-19 13:53 ` Masami Hiramatsu
2025-03-19 8:11 ` [PATCH v3 3/3] samples: extend hung_task detector test with semaphore support Lance Yang
2025-03-19 13:49 ` Masami Hiramatsu
2025-03-19 14:59 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319081138.25133-1-ioworker0@gmail.com \
--to=ioworker0@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amaindex@outlook.com \
--cc=anna.schumaker@oracle.com \
--cc=boqun.feng@gmail.com \
--cc=joel.granados@kernel.org \
--cc=jstultz@google.com \
--cc=kent.overstreet@linux.dev \
--cc=leonylgao@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox