From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
alx@kernel.org, brauner@kernel.org, djwong@kernel.org,
dchinner@redhat.com, linux-man@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, ojaswin@linux.ibm.com,
ritesh.list@gmail.com, martin.petersen@oracle.com
Subject: Re: [PATCH RFC] statx.2: Add stx_atomic_write_unit_max_opt
Date: Thu, 20 Mar 2025 15:12:00 +0100 [thread overview]
Message-ID: <20250320141200.GC10939@lst.de> (raw)
In-Reply-To: <c656fa4d-eb76-4caa-8a71-a8d8a2ba6206@oracle.com>
On Thu, Mar 20, 2025 at 09:19:40AM +0000, John Garry wrote:
> But is there value in reporting this limit? I am not sure. I am not sure
> what the user would do with this info.
Align their data structures to it, e.g. size the log buffers to it.
> Maybe, for example, they want to write 1K consecutive 16K pages, each
> atomically, and decide to do a big 16M atomic write but find that it is
> slow as bdev atomic limit is < 16M.
>
> Maybe I should just update the documentation to mention that for XFS they
> should check the mounted bdev atomic limits.
For something working on files having to figure out the underlying
block device (which is non-trivial given the various methods of
multi-device support) and then looking into block sysfs is a no-go.
So if we have any sort of use case for it we should expose the limit.
next prev parent reply other threads:[~2025-03-20 14:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 11:44 [PATCH RFC] statx.2: Add stx_atomic_write_unit_max_opt John Garry
2025-03-20 7:00 ` Christoph Hellwig
2025-03-20 9:19 ` John Garry
2025-03-20 14:12 ` Christoph Hellwig [this message]
2025-03-21 10:20 ` John Garry
2025-03-23 6:40 ` Christoph Hellwig
2025-04-03 15:07 ` John Garry
2025-04-04 9:06 ` Christoph Hellwig
2025-04-04 9:23 ` John Garry
2025-04-07 6:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320141200.GC10939@lst.de \
--to=hch@lst.de \
--cc=alx@kernel.org \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox