Re: [PATCH v1 3/6] tracing: Mark binary printing functions with __printf() attribute

Andy Shevchenko
2025-03-21T14:09:42Z

On Thu, Mar 20, 2025 at 08:04:24PM +0200, Andy Shevchenko wrote:
> Binary printing functions are using printf() type of format, and compiler
> is not happy about them as is:
>
> kernel/trace/trace.c:3292:9: error: function ‘trace_vbprintk’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
> kernel/trace/trace_seq.c:182:9: error: function ‘trace_seq_bprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>
> Fix the compilation errors by adding __printf() attribute.
>
> While at it, move existing __printf() attributes from the implementations
> to the declarations.

This also missed removal of one new line and __printf() in the C file.
Will be improved in v2.

--
With Best Regards,
Andy Shevchenko