public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: 邵培杰 <shaopeijie@cestc.cn>
Cc: Christoph Hellwig <hch@lst.de>, kbusch <kbusch@kernel.org>,
	axboe <axboe@kernel.dk>, sagi <sagi@grimberg.me>,
	linux-nvme <linux-nvme@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"zhang.guanghui " <zhang.guanghui@cestc.cn>,
	gechangzhong <gechangzhong@cestc.cn>
Subject: Re: [PATCH] nvme-tcp: fix selinux denied when calling sock_sendmsg
Date: Fri, 21 Mar 2025 06:05:38 +0100	[thread overview]
Message-ID: <20250321050538.GA2038@lst.de> (raw)
In-Reply-To: <1382721899.82743.1742525374789.JavaMail.xmail@wm-2>

[note: your mail was mangled html, I'm trying to extract the answer]

On Fri, Mar 21, 2025 at 10:49:34AM +0800, 邵培杰 wrote:
> Sure. But on the target side, it's a bit different.
> All socket operations are done in the workqueue with domain kernel_t,
> the kernel_t can access other labels, so I think there's no issue.

Indeed.

> By
> the way, switching to sock_create_kern() could skip selinux avc
> permission check and might give a very small performance boost.

It also helps to avoid copy and paste bugs..

> I'll send an optimization patch later.

Thanks!

  parent reply	other threads:[~2025-03-21  5:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20  6:35 [PATCH] nvme-tcp: fix selinux denied when calling sock_sendmsg shaopeijie
2025-03-20  7:25 ` Christoph Hellwig
     [not found]   ` <1382721899.82743.1742525374789.JavaMail.xmail@wm-2>
2025-03-21  5:05     ` Christoph Hellwig [this message]
2025-03-20 20:15 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250321050538.GA2038@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=gechangzhong@cestc.cn \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=shaopeijie@cestc.cn \
    --cc=zhang.guanghui@cestc.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox