From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 598E08836 for ; Fri, 21 Mar 2025 06:19:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742537967; cv=none; b=NnLbf3oYzS2irTUgf+fDSSS/A7cYRK+Fpm5N07DJto1vSDU0snbXZDPErLm1p74CaQ8e+rTsmkOEnuE8bdVWqTREtE4yBzzKjouCBMpEHHm8O7vHDmSvp6JRBCf5NFCTsoEIwKYpZAl55wA6L4j3KCGWBf9RPcJCdP3SCwaejg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742537967; c=relaxed/simple; bh=27KmGi7h5nB1p8p4616q7p1chkRefL+ulFQEMrpSQVk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O8aHjoC8NXo5b5X3RZGVHKz7RP9uCdmPNqPcUTb8LvHyulEQuU0atkMG8XogbIMG1Mhxd0O2m58scPZ8d7TYp/djgogTm9ss6NduMd3hj2rIc4MadhMYVWYiAMk3J6ituIHHMoRQQN4N8XfJKxBoH5+FH9YfviikVyZCaxh172A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 8ABA768AA6; Fri, 21 Mar 2025 07:19:22 +0100 (CET) Date: Fri, 21 Mar 2025 07:19:22 +0100 From: Christoph Hellwig To: Daniel Wagner Cc: James Smart , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Hannes Reinecke , Keith Busch , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 17/18] nvmet-fc: put ref when assoc->del_work is already scheduled Message-ID: <20250321061922.GH3198@lst.de> References: <20250318-nvmet-fcloop-v3-0-05fec0fc02f6@kernel.org> <20250318-nvmet-fcloop-v3-17-05fec0fc02f6@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250318-nvmet-fcloop-v3-17-05fec0fc02f6@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Mar 18, 2025 at 11:40:11AM +0100, Daniel Wagner wrote: > Do not leak the tgtport reference when the work is already scheduled. Looks good: Reviewed-by: Christoph Hellwig