From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31911F8F09; Fri, 21 Mar 2025 13:10:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742562626; cv=none; b=VuJ3DMAM67vaMqq7Jk5rGQye8kVzC5dMH3JKSuZUKJeXnVWtJm3hTDIABlgJ+kGU2ZM6ZcP+v49HTbu4q+B/L2ymQz5b74ghHw8H8CPpo0i8Ryvd1It+AlQhn1fCWC9+IY8hBnWH0rHFxpGO1TaFwCVcaBXjXruDbK3nhuBMBzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742562626; c=relaxed/simple; bh=lkJ795Xi3YIfzoTXYBWBB7Bfltn4j1dL37rIVKkwt7o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FCNqPcVRGVvaQqVjxg3jxYkF9Eh8PxN+rzGVv82Xked8pEccnGMDN3AFr8H4LdB4S85NxR1hBZOeQlIOW/hp76TXLfZtFayKvnC9FygXSdA1cSAHKAfJHpYGl5hJwdyIW4nD+vnsR4eTu1iobYEBB/xm/bo7iI901Rtg9fb631w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fPlzFkeq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fPlzFkeq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FC37C4CEE3; Fri, 21 Mar 2025 13:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1742562626; bh=lkJ795Xi3YIfzoTXYBWBB7Bfltn4j1dL37rIVKkwt7o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fPlzFkeq2fOofhZa+osFQRaCQ1shTkGXZ/jV8VPJKhd2ycixksKj2G520II+MS/7E 2VC83MnnmcCqQ1tUW+HXmPf3rM6+ftCS2xhHFoBEM62RWoBxLhtr2r0FDevZ1B/8YY lnQbH9am6F5k8GrNrpfe0h5Am+EIieF7PY7Rj/Fg= Date: Fri, 21 Mar 2025 06:09:06 -0700 From: Greg KH To: Danilo Krummrich Cc: bhelgaas@google.com, rafael@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] rust: device: implement Device::parent() Message-ID: <2025032149-erasure-halt-d179@gregkh> References: <20250320222823.16509-1-dakr@kernel.org> <20250320222823.16509-2-dakr@kernel.org> <2025032018-perceive-expectant-5c48@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Mar 21, 2025 at 02:03:30PM +0100, Danilo Krummrich wrote: > So, maybe we should make Device::parent() crate private instead, such that it > can't be accessed by drivers, but only the core abstractions and instead only > provide accessors for the parent device for specific bus devices, where this is > reasonable to be used by drivers, e.g. auxiliary. > That sounds reasonable, thanks! greg k-h