From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com
Cc: xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 17/19] virtio_ring: move next_avail_idx to vring_virtqueue
Date: Mon, 24 Mar 2025 14:01:25 +0800 [thread overview]
Message-ID: <20250324060127.2358-5-jasowang@redhat.com> (raw)
In-Reply-To: <20250324054333.1954-1-jasowang@redhat.com>
This variable is used by packed virtqueue now, moving it to
vring_virtqueue to make it possible to be reused by split virtqueue
in-order implementation.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/virtio/virtio_ring.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index bd4faf04862c..a1a8cd931052 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -138,9 +138,6 @@ struct vring_virtqueue_packed {
/* Avail used flags. */
u16 avail_used_flags;
- /* Index of the next avail descriptor. */
- u16 next_avail_idx;
-
/*
* Last written value to driver->flags in
* guest byte order.
@@ -214,6 +211,9 @@ struct vring_virtqueue {
*/
u16 last_used_idx;
+ /* Index of the next avail descriptor. */
+ u16 next_avail_idx;
+
/* Hint for event idx: already triggered no need to disable. */
bool event_triggered;
@@ -448,6 +448,7 @@ static void virtqueue_init(struct vring_virtqueue *vq, u32 num)
else
vq->last_used_idx = 0;
+ vq->next_avail_idx = 0;
vq->event_triggered = false;
vq->num_added = 0;
@@ -1350,7 +1351,7 @@ static int virtqueue_add_indirect_packed(struct vring_virtqueue *vq,
u16 head, id;
dma_addr_t addr;
- head = vq->packed.next_avail_idx;
+ head = vq->next_avail_idx;
desc = alloc_indirect_packed(total_sg, gfp);
if (!desc)
return -ENOMEM;
@@ -1431,7 +1432,7 @@ static int virtqueue_add_indirect_packed(struct vring_virtqueue *vq,
1 << VRING_PACKED_DESC_F_AVAIL |
1 << VRING_PACKED_DESC_F_USED;
}
- vq->packed.next_avail_idx = n;
+ vq->next_avail_idx = n;
vq->free_head = vq->packed.desc_extra[id].next;
/* Store token and indirect buffer state. */
@@ -1501,7 +1502,7 @@ static inline int virtqueue_add_packed(struct vring_virtqueue *vq,
/* fall back on direct */
}
- head = vq->packed.next_avail_idx;
+ head = vq->next_avail_idx;
avail_used_flags = vq->packed.avail_used_flags;
WARN_ON_ONCE(total_sg > vq->packed.vring.num && !vq->indirect);
@@ -1569,7 +1570,7 @@ static inline int virtqueue_add_packed(struct vring_virtqueue *vq,
vq->vq.num_free -= descs_used;
/* Update free pointer */
- vq->packed.next_avail_idx = i;
+ vq->next_avail_idx = i;
vq->free_head = curr;
/* Store token. */
@@ -1633,8 +1634,8 @@ static bool virtqueue_kick_prepare_packed(struct vring_virtqueue *vq)
*/
virtio_mb(vq->weak_barriers);
- old = vq->packed.next_avail_idx - vq->num_added;
- new = vq->packed.next_avail_idx;
+ old = vq->next_avail_idx - vq->num_added;
+ new = vq->next_avail_idx;
vq->num_added = 0;
snapshot.u32 = *(u32 *)vq->packed.vring.device;
@@ -2083,7 +2084,6 @@ static int vring_alloc_state_extra_packed(struct vring_virtqueue_packed *vring_p
static void virtqueue_vring_init_packed(struct vring_virtqueue_packed *vring_packed,
bool callback)
{
- vring_packed->next_avail_idx = 0;
vring_packed->avail_wrap_counter = 1;
vring_packed->event_flags_shadow = 0;
vring_packed->avail_used_flags = 1 << VRING_PACKED_DESC_F_AVAIL;
@@ -2977,7 +2977,7 @@ u32 vring_notification_data(struct virtqueue *_vq)
u16 next;
if (vq->packed_ring)
- next = (vq->packed.next_avail_idx &
+ next = (vq->next_avail_idx &
~(-(1 << VRING_PACKED_EVENT_F_WRAP_CTR))) |
vq->packed.avail_wrap_counter <<
VRING_PACKED_EVENT_F_WRAP_CTR;
--
2.42.0
next prev parent reply other threads:[~2025-03-24 6:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 5:43 [PATCH 00/19] virtio_ring in order support Jason Wang
2025-03-24 5:43 ` [PATCH 01/19] virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx() Jason Wang
2025-03-26 12:08 ` Eugenio Perez Martin
2025-03-24 5:43 ` [PATCH 02/19] virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants Jason Wang
2025-03-26 12:09 ` Eugenio Perez Martin
2025-03-24 5:43 ` [PATCH 03/19] virtio_ring: unify logic of virtqueue_poll() and more_used() Jason Wang
2025-03-24 5:43 ` [PATCH 04/19] virtio_ring: switch to use vring_virtqueue for virtqueue resize variants Jason Wang
2025-03-26 12:29 ` Eugenio Perez Martin
2025-03-24 5:43 ` [PATCH 05/19] virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare variants Jason Wang
2025-03-26 12:29 ` Eugenio Perez Martin
2025-03-24 5:43 ` [PATCH 06/19] virtio_ring: switch to use vring_virtqueue for virtqueue_add variants Jason Wang
2025-03-26 12:29 ` Eugenio Perez Martin
2025-03-24 5:43 ` [PATCH 07/19] virtio: " Jason Wang
2025-03-26 12:30 ` Eugenio Perez Martin
2025-03-24 5:43 ` [PATCH 08/19] virtio_ring: switch to use vring_virtqueue for enable_cb_prepare variants Jason Wang
2025-03-26 12:30 ` Eugenio Perez Martin
2025-03-24 5:43 ` [PATCH 09/19] virtio_ring: use vring_virtqueue for enable_cb_delayed variants Jason Wang
2025-03-26 12:30 ` Eugenio Perez Martin
2025-03-24 5:43 ` [PATCH 10/19] virtio_ring: switch to use vring_virtqueue for disable_cb variants Jason Wang
2025-03-26 12:30 ` Eugenio Perez Martin
2025-03-24 5:43 ` [PATCH 11/19] virtio_ring: switch to use vring_virtqueue for detach_unused_buf variants Jason Wang
2025-03-26 12:31 ` Eugenio Perez Martin
2025-03-24 5:43 ` [PATCH 12/19] virtio_ring: use u16 for last_used_idx in virtqueue_poll_split() Jason Wang
2025-03-26 12:31 ` Eugenio Perez Martin
2025-03-24 6:01 ` [PATCH 13/19] virtio_ring: introduce virtqueue ops Jason Wang
2025-03-26 12:32 ` Eugenio Perez Martin
2025-04-07 8:20 ` Michael S. Tsirkin
2025-04-08 7:02 ` Jason Wang
2025-04-08 11:36 ` Michael S. Tsirkin
2025-04-09 4:06 ` Jason Wang
2025-05-14 14:19 ` Michael S. Tsirkin
2025-05-14 14:24 ` Michael S. Tsirkin
2025-05-16 1:30 ` Jason Wang
2025-05-16 10:35 ` Michael S. Tsirkin
2025-05-19 7:33 ` Jason Wang
2025-03-24 6:01 ` [PATCH 14/19] virtio_ring: determine descriptor flags at one time Jason Wang
2025-03-26 13:58 ` Eugenio Perez Martin
2025-03-24 6:01 ` [PATCH 15/19] virtio_ring: factor out core logic of buffer detaching Jason Wang
2025-03-26 13:59 ` Eugenio Perez Martin
2025-03-24 6:01 ` [PATCH 16/19] virtio_ring: factor out core logic for updating last_used_idx Jason Wang
2025-03-26 14:00 ` Eugenio Perez Martin
2025-03-24 6:01 ` Jason Wang [this message]
2025-03-26 14:01 ` [PATCH 17/19] virtio_ring: move next_avail_idx to vring_virtqueue Eugenio Perez Martin
2025-03-24 6:01 ` [PATCH 18/19] virtio_ring: factor out split indirect detaching logic Jason Wang
2025-03-26 14:02 ` Eugenio Perez Martin
2025-03-24 6:01 ` [PATCH 19/19] virtio_ring: add in order support Jason Wang
2025-03-24 14:43 ` [PATCH 00/19] virtio_ring " Lei Yang
2025-03-26 6:39 ` Eugenio Perez Martin
2025-05-18 21:34 ` Michael S. Tsirkin
2025-05-22 7:01 ` Lei Yang
2025-05-27 1:26 ` Lei Yang
2025-03-31 1:49 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324060127.2358-5-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=eperezma@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox