Re: [PATCH net-next v4 8/8] net: ethtool: pse-pd: Use per-PHY DUMP operations

Kory Maincent
2025-03-25T13:35:05Z

On Mon, 24 Mar 2025 11:40:10 +0100
Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:

> Leverage the per-phy ethnl DUMP helpers in case we have more that one
> PSE PHY on the link.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> V4 : No changes
>
> net/ethtool/pse-pd.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/ethtool/pse-pd.c b/net/ethtool/pse-pd.c
> index 4f6b99eab2a6..f3d14be8bdd9 100644
> --- a/net/ethtool/pse-pd.c
> +++ b/net/ethtool/pse-pd.c
> @@ -314,4 +314,10 @@ const struct ethnl_request_ops ethnl_pse_request_ops = {
>
> .set = ethnl_set_pse,
> /* PSE has no notification */
> +
> + .dump_start = ethnl_dump_start_perphy,
> + .dump_one_dev = ethnl_dump_one_dev_perphy,
> + .dump_done = ethnl_dump_done_perphy,
> +
> + .allow_pernetdev_dump = true,
> };

Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>

Thank you!

--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering