Re: [PATCH net-next v4 2/8] net: ethtool: netlink: Allow per-netdevice DUMP operations

Kory Maincent
2025-03-26T10:29:42Z

On Wed, 26 Mar 2025 08:59:06 +0100
Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:

> On Tue, 25 Mar 2025 14:22:02 -0700
> Jakub Kicinski <kuba@kernel.org> wrote:
>
> > On Tue, 25 Mar 2025 14:15:07 -0700 Jakub Kicinski wrote:
> [...]
> > >
> > > Let's try. We can probably make required_dev attr of
> > > ethnl_parse_header_dev_get() a three state one: require, allow, reject?
> > >
> >
> > Ah, don't think this is going to work. You're not converting all
> > the dumps, just the PHY ones. It's fine either way, then.
>
> Yeah I noticed that when implementing, but I actually forgot to mention
> in in my cover, which I definitely should have :(
>
> What we can also do is properly support multi-phy dump but not filtered
> dump on all the existing phy commands (plca, pse-pd, etc.) so that be
> behaviour is unchanged for these. Only PHY_GET and any future per-phy
> commands would support it.

Couldn't we remove the existence check of ctx->req_info->dev in
ethnl_default_start and add the netdev_put() in the ethnl_default_dumpit()?
Would this work?

Or we could keep your change and let the userspace adapt to the new support of
filtered dump. In fact you are modifying all the ethtool commands that are
already related to PHY, if you don't they surely will one day or another so it
is good to keep it.

Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering