From: Leo Yan <leo.yan@arm.com>
To: Marcus Meissner <meissner@suse.de>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, carsten.haitzler@arm.com,
james.clark@linaro.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: annotate asm_pure_loop.S
Date: Mon, 24 Mar 2025 11:34:45 +0000 [thread overview]
Message-ID: <20250324113445.GA604566@e132581.arm.com> (raw)
In-Reply-To: <20250323085410.23751-1-meissner@suse.de>
On Sun, Mar 23, 2025 at 09:53:45AM +0100, Marcus Meissner wrote:
> Annotate so it is built with non-executable stack.
>
> Fixes: 8b97519711c3a0f9eb8274a227dff3fe4f0f72a2
Fixes: 8b97519711c3 ("perf test: Add asm pureloop test tool")
> Signed-off-by: Marcus Meissner <meissner@suse.de>
> ---
> tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S b/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
> index 75cf084a927d..577760046772 100644
> --- a/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
> +++ b/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
> @@ -26,3 +26,5 @@ skip:
> mov x0, #0
> mov x8, #93 // __NR_exit syscall
> svc #0
> +
> +.section .note.GNU-stack, "", @progbits
With the fix tag change:
Reviewed-by: Leo Yan <leo.yan@arm.com>
I found actually Jan Stancek has submitted a similiar patch [1]
~2 years ago but we missed, sorry for that.
[1] https://lore.kernel.org/linux-perf-users/e79288922fbd0bad6facf06488735ec74f811d1b.1689588798.git.jstancek@redhat.com/
next prev parent reply other threads:[~2025-03-24 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-23 8:53 [PATCH] perf: annotate asm_pure_loop.S Marcus Meissner
2025-03-24 11:34 ` Leo Yan [this message]
2025-03-25 19:49 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324113445.GA604566@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=carsten.haitzler@arm.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=meissner@suse.de \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox