From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Subject: [PATCH net v3 0/2] net: usb: asix: ax88772: Fix potential string cut
Date: Mon, 24 Mar 2025 16:39:28 +0200 [thread overview]
Message-ID: <20250324144751.1271761-1-andriy.shevchenko@linux.intel.com> (raw)
The agreement and also PHY_MAX_ADDR limit suggest that the PHY address
can't occupy more than two hex digits. In some cases GCC complains about
potential string cut. In course of fixing this, introduce the PHY_ID_SIZE
predefined constant to make it easier for the users to know the bare
minimum for the buffer that holds PHY ID string (patch 1). With that,
fix the ASIX driver that triggers GCC accordingly (patch 2).
In v3:
- dropped format specifier changes (Russell, LKP)
- added predefined constant for a minimum buffer size (Russell)
- updated error message to refer to the address and not ID string (Russell)
- changed type of phy_addr to u8, otherwise GCC can't cope with its range
In v2:
- added first patch
- added a conditional to the ASIX driver (Andrew)
Andy Shevchenko (2):
net: phy: Introduce PHY_ID_SIZE — minimum size for PHY ID string
net: usb: asix: ax88772: Increase phy_name size
drivers/net/usb/ax88172a.c | 12 ++++++++----
include/linux/phy.h | 1 +
2 files changed, 9 insertions(+), 4 deletions(-)
--
2.47.2
next reply other threads:[~2025-03-24 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 14:39 Andy Shevchenko [this message]
2025-03-24 14:39 ` [PATCH net v3 1/2] net: phy: Introduce PHY_ID_SIZE — minimum size for PHY ID string Andy Shevchenko
2025-03-24 15:06 ` Russell King (Oracle)
2025-03-24 15:57 ` Andy Shevchenko
2025-03-24 17:38 ` Russell King (Oracle)
2025-03-24 19:52 ` Andy Shevchenko
2025-03-24 14:39 ` [PATCH net v3 2/2] net: usb: asix: ax88772: Increase phy_name size Andy Shevchenko
2025-03-25 22:50 ` [PATCH net v3 0/2] net: usb: asix: ax88772: Fix potential string cut patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324144751.1271761-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox