Re: [PATCH net-next 13/13] MIPS: mobileye: eyeq5-epm: add two Cadence GEM Ethernet PHYs

Andrew Lunn
2025-03-21T21:17:06Z

On Fri, Mar 21, 2025 at 08:09:44PM +0100, Théo Lebrun wrote:
> The Mobileye EyeQ5 eval board (EPM) embeds two MDIO PHYs.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
> arch/mips/boot/dts/mobileye/eyeq5-epm5.dts | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/mips/boot/dts/mobileye/eyeq5-epm5.dts b/arch/mips/boot/dts/mobileye/eyeq5-epm5.dts
> index 6898b2d8267dfadeea511a84d1df3f70744f17bb..20dfc85681bb03330981ca0f11b2edfff3fa57bc 100644
> --- a/arch/mips/boot/dts/mobileye/eyeq5-epm5.dts
> +++ b/arch/mips/boot/dts/mobileye/eyeq5-epm5.dts
> @@ -21,3 +21,29 @@ memory@0 {
> <0x8 0x02000000 0x0 0x7E000000>;
> };
> };
> +
> +&macb0 {
> + phy-mode = "sgmii";
> + phy-handle = <&macb0_phy>;
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + macb0_phy: ethernet-phy@e {
> + reg = <0xE>;

The DT coding style might say this should be lower case?

> + };
> + };
> +};
> +
> +&macb1 {
> + phy-mode = "rgmii-id";

Hurrah. A correct rgmii phy-mode.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Andrew