From: Oleg Nesterov <oleg@redhat.com>
To: Jann Horn <jannh@google.com>
Cc: x86@kernel.org, Andy Lutomirski <luto@kernel.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Dominik Brodowski <linux@dominikbrodowski.net>,
Ingo Molnar <mingo@kernel.org>,
Vernon Lovejoy <vlovejoy@redhat.com>
Subject: Re: [PATCH 2/2] x86/dumpstack: Fix broken unwinding from exception stacks
Date: Tue, 25 Mar 2025 14:27:35 +0100 [thread overview]
Message-ID: <20250325132735.GC7904@redhat.com> (raw)
In-Reply-To: <20250325-2025-03-unwind-fixes-v1-2-acd774364768@google.com>
On 03/25, Jann Horn wrote:
>
> Commit 2e4be0d011f2 ("x86/show_trace_log_lvl: Ensure stack pointer is
> aligned, again") was intended to ensure alignment of the stack pointer; but
> it also moved the initialization of the "stack" variable down into the loop
> header. This was likely intended as a no-op cleanup, since the commit
> message does not mention it;
Yes... initial version didn't do this, this was requested during review
and I didn't realize this adds another problem.
Thanks Jann!
Oleg.
prev parent reply other threads:[~2025-03-25 13:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 2:01 [PATCH 0/2] x86 unwind fixes (1 unwinder fix, 1 missing entry ORC annotation) Jann Horn
2025-03-25 2:01 ` [PATCH 1/2] x86/entry: Fix ORC for PUSH_REGS with save_ret=1 Jann Horn
2025-03-25 7:46 ` [tip: x86/urgent] x86/entry: Fix ORC unwinder " tip-bot2 for Jann Horn
2025-03-25 2:01 ` [PATCH 2/2] x86/dumpstack: Fix broken unwinding from exception stacks Jann Horn
2025-03-25 2:24 ` Jann Horn
2025-03-25 7:31 ` Ingo Molnar
2025-03-25 7:46 ` [tip: x86/urgent] x86/dumpstack: Fix inaccurate unwinding from exception stacks due to misplaced assignment tip-bot2 for Jann Horn
2025-03-25 13:27 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325132735.GC7904@redhat.com \
--to=oleg@redhat.com \
--cc=jannh@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vlovejoy@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox