public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Guomin chen <guomin.chen@cixtech.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Peter Chen <peter.chen@cixtech.com>,
	cix-kernel-upstream@cixtech.com, linux-kernel@vger.kernel.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mailbox: add cix,sky1-mbox
Date: Tue, 25 Mar 2025 09:01:36 -0500	[thread overview]
Message-ID: <20250325140136.GA1843686-robh@kernel.org> (raw)
In-Reply-To: <Z+KxIRVRRw1slKqB@gchen>

On Tue, Mar 25, 2025 at 01:35:29PM +0000, Guomin chen wrote:
> On Tue, Mar 25, 2025 at 07:55:10AM -0500, Rob Herring (Arm) wrote:
> > [Some people who received this message don't often get email from robh@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> > 
> > EXTERNAL EMAIL
> > 
> > On Tue, 25 Mar 2025 10:18:06 +0000, Guomin Chen wrote:
> > > From: Guomin Chen <Guomin.Chen@cixtech.com>
> > >
> > > Add a dt-binding for the Cixtech Mailbox Controller.
> > >
> > > Reviewed-by: Peter Chen <peter.chen@cixtech.com>
> > > Signed-off-by: Lihua Liu <Lihua.Liu@cixtech.com>
> > > Signed-off-by: Guomin Chen <Guomin.Chen@cixtech.com>
> > > ---
> > >  .../bindings/mailbox/cix,sky1-mbox.yaml       | 80 +++++++++++++++++++
> > >  1 file changed, 80 insertions(+)
> > >
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> ...
> >  l,.*', 'pinctrl-[0-9]+'
> >         from schema $id: http://devicetree.org/schemas/vendor-prefixes.yaml#
> > 
> > doc reference errors (make refcheckdocs):
> > 
> > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250325101807.2202758-2-guomin.chen@cixtech.com
> > 
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit after running the above command yourself. Note
> > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > your schema. However, it must be unset to test all examples with your schema.
> > 
> 
> Thank you very much. 
> Although I have already run 'make dt_binding_check DT_SCHEMA_FILES=mailbox/cix,sky1-mbox.yaml' in my environment.
> I will try updating dtschema and re-check it.

With DT_SCHEMA_FILES you only check what matches. You have to run 
without it.

Rob


  reply	other threads:[~2025-03-25 14:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25 10:18 [PATCH v2 0/2] mailbox: add Cixtech mailbox driver Guomin Chen
2025-03-25 10:18 ` [PATCH v2 1/2] dt-bindings: mailbox: add cix,sky1-mbox Guomin Chen
2025-03-25 10:36   ` Krzysztof Kozlowski
2025-03-28  3:13     ` Guomin chen
2025-03-28  7:12       ` Krzysztof Kozlowski
2025-03-28  8:49         ` Guomin chen
2025-03-25 12:55   ` Rob Herring (Arm)
2025-03-25 13:35     ` Guomin chen
2025-03-25 14:01       ` Rob Herring [this message]
2025-03-25 10:18 ` [PATCH v2 2/2] mailbox: add Cixtech mailbox driver Guomin Chen
2025-03-25 10:39   ` Krzysztof Kozlowski
2025-03-25 13:44     ` Guomin chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250325140136.GA1843686-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=guomin.chen@cixtech.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.chen@cixtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox