From: Rob Herring <robh@kernel.org>
To: "J. Neuschäfer" <j.ne@posteo.net>
Cc: Simon Glass <sjg@chromium.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH RESEND] scripts/make_fit: Print DT name before libfdt errors
Date: Tue, 25 Mar 2025 15:05:44 -0500 [thread overview]
Message-ID: <20250325200544.GA2195874-robh@kernel.org> (raw)
In-Reply-To: <20250209-makefit-v1-1-bfe6151e8f0a@posteo.net>
On Sun, Feb 09, 2025 at 05:55:28PM +0100, J. Neuschäfer wrote:
> This makes it easier to pinpoint where the error happened. For example:
>
> FIT arch/powerpc/boot/image.fit
> Error processing arch/powerpc/boot/dts/microwatt.dtb:
> Traceback (most recent call last):
> File "/home/jn/dev/linux/linux-git/build-mpc83xx/../scripts/make_fit.py", line 335, in <module>
> sys.exit(run_make_fit())
> ^^^^^^^^^^^^^^
> File "/home/jn/dev/linux/linux-git/build-mpc83xx/../scripts/make_fit.py", line 309, in run_make_fit
> out_data, count, size = build_fit(args)
> ^^^^^^^^^^^^^^^
> File "/home/jn/dev/linux/linux-git/build-mpc83xx/../scripts/make_fit.py", line 286, in build_fit
> raise e
> File "/home/jn/dev/linux/linux-git/build-mpc83xx/../scripts/make_fit.py", line 283, in build_fit
> (model, compat, files) = process_dtb(fname, args)
> ^^^^^^^^^^^^^^^^^^^^^^^^
> File "/home/jn/dev/linux/linux-git/build-mpc83xx/../scripts/make_fit.py", line 231, in process_dtb
> model = fdt.getprop(0, 'model').as_str()
> ^^^^^^^^^^^^^^^^^^^^^^^
> File "/usr/lib/python3/dist-packages/libfdt.py", line 448, in getprop
> pdata = check_err_null(fdt_getprop(self._fdt, nodeoffset, prop_name),
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/usr/lib/python3/dist-packages/libfdt.py", line 153, in check_err_null
> raise FdtException(val)
> libfdt.FdtException: pylibfdt error -1: FDT_ERR_NOTFOUND
>
> Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> ---
> The example is from a different series which I will release soon, which
> enables FIT on powerpc.
> ---
> scripts/make_fit.py | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Applied, sorry for the delay.
Rob
prev parent reply other threads:[~2025-03-25 20:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 16:55 [PATCH RESEND] scripts/make_fit: Print DT name before libfdt errors J. Neuschäfer via B4 Relay
2025-03-25 20:05 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325200544.GA2195874-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j.ne@posteo.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox