Re: [PATCH net-next v4 0/8] net: ethtool: Introduce ethnl dump helpers

Jakub Kicinski
2025-03-25T21:31:22Z

On Mon, 24 Mar 2025 11:40:02 +0100 Maxime Chevallier wrote:
> The patches 1 and 2 introduce the support for filtered DUMPs, where an
> ifindex/ifname can be passed in the request header for the DUMP
> operation. This is for when we want to dump everything a netdev
> supports, but without doing so for every single netdev. ethtool's
> "--show-phys ethX" option for example performs a filtered dump.
>
> Patch 3 introduces 3 new ethnl ops :
> ->dump_start() to initialize a dump context
> ->dump_one_dev(), that can be implemented per-command to dump
> everything on a given netdev
> ->dump_done() to release the context

Did you consider ignoring the RSS and focusing purely on PHYs?
The 3 callbacks are a bit generic, but we end up primarily
using them for PHY stuff. And the implementations still need
to call ethnl_req_get_phydev() AFAICT