public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Huan Yang <link@vivo.com>
To: bingbu.cao@linux.intel.com,
	"Matthew Wilcox" <willy@infradead.org>,
	"Christoph Hellwig" <hch@lst.de>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Vivek Kasireddy" <vivek.kasireddy@intel.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Uladzislau Rezki" <urezki@gmail.com>,
	"Shuah Khan" <shuah@kernel.org>, "Huan Yang" <link@vivo.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Cc: opensource.kernel@vivo.com
Subject: [RFC PATCH 5/6] udmabuf: vmap test suit for pages and pfns compare
Date: Thu, 27 Mar 2025 17:28:32 +0800	[thread overview]
Message-ID: <20250327092922.536-6-link@vivo.com> (raw)
In-Reply-To: <20250327092922.536-1-link@vivo.com>

This patch both compare pages and pfns based vmap, to show folios
range vmap and pfn range vmap can work.

Signed-off-by: Huan Yang <link@vivo.com>
---
 drivers/dma-buf/udmabuf.c | 64 ++++++++++++++++++++++++++++-----------
 1 file changed, 46 insertions(+), 18 deletions(-)

diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index f50e11f0f034..78549a9f24ca 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -556,6 +556,48 @@ static long udmabuf_ioctl_create_list(struct file *filp, unsigned long arg)
 	return ret;
 }
 
+static void *udmabuf_vmap_by_pfns(struct udmabuf *udmabuf)
+{
+	unsigned long *pfns;
+	void *vaddr = NULL;
+	unsigned int i;
+
+	pfns = kvmalloc_array(udmabuf->pagecount, sizeof(*pfns), GFP_KERNEL);
+	if (WARN_ON(!pfns))
+		return NULL;
+
+	for (i = 0; i < udmabuf->pagecount; ++i)
+		pfns[i] = folio_pfn(udmabuf->folios[i]) +
+			  (udmabuf->offsets[i] >> PAGE_SHIFT);
+
+	vaddr = udmabuf_vmap_pfn(pfns, udmabuf->pagecount, PAGE_KERNEL);
+	WARN_ON(!vaddr);
+
+	kvfree(pfns);
+	return vaddr;
+}
+
+static void *udmabuf_vmap_by_pages(struct udmabuf *udmabuf)
+{
+	struct page **pages;
+	void *vaddr = NULL;
+	unsigned int i;
+
+	pages = kvmalloc_array(udmabuf->pagecount, sizeof(*pages), GFP_KERNEL);
+	if (WARN_ON(!pages))
+		return NULL;
+
+	for (i = 0; i < udmabuf->pagecount; ++i)
+		pages[i] = folio_page(udmabuf->folios[i],
+				      udmabuf->offsets[i] >> PAGE_SHIFT);
+
+	vaddr = vmap(pages, udmabuf->pagecount, 0, PAGE_KERNEL);
+	WARN_ON(!vaddr);
+
+	kvfree(pages);
+	return vaddr;
+}
+
 static long udmabuf_vmap_test(struct file *filp, unsigned long arg)
 {
 	struct udmabuf_vmap uv;
@@ -563,7 +605,6 @@ static long udmabuf_vmap_test(struct file *filp, unsigned long arg)
 	bool can_page = true;
 	struct iosys_map map;
 	struct udmabuf *ubuf;
-	struct page **pages;
 	void *vaddr, *pvaddr;
 	struct file *file;
 	int ret = 0, i;
@@ -591,31 +632,18 @@ static long udmabuf_vmap_test(struct file *filp, unsigned long arg)
 	}
 
 	if (!can_page)
-		goto out_vaddr;
+		pvaddr = udmabuf_vmap_by_pfns(ubuf);
+	else
+		pvaddr = udmabuf_vmap_by_pages(ubuf);
 
-	pages = kvmalloc_array(ubuf->pagecount, sizeof(*pages), GFP_KERNEL);
-	if (WARN_ON(!pages)) {
-		ret = -ENOMEM;
+	if (!pvaddr)
 		goto out_vaddr;
-	}
-
-	for (i = 0; i < ubuf->pagecount; ++i)
-		pages[i] = folio_page(ubuf->folios[i],
-				      ubuf->offsets[i] >> PAGE_SHIFT);
-
-	pvaddr = vmap(pages, ubuf->pagecount, 0, PAGE_KERNEL);
-	if (WARN_ON(!pvaddr)) {
-		ret = -ENOMEM;
-		goto out_pages;
-	}
 
 	// compare if pages and pfns is same?
 	if (WARN_ON(memcmp(vaddr, pvaddr, ubuf->pagecount * PAGE_SIZE) != 0))
 		ret = -EINVAL;
 
 	vunmap(pvaddr);
-out_pages:
-	kvfree(pages);
 out_vaddr:
 	dma_buf_vunmap(dmabuf, &map);
 out:
-- 
2.48.1


  parent reply	other threads:[~2025-03-27  9:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-27  9:28 [RFC PATCH 0/6] Deep talk about folio vmap Huan Yang
2025-03-27  9:28 ` [RFC PATCH 1/6] udmabuf: try fix udmabuf vmap Huan Yang
2025-03-27  9:28 ` [RFC PATCH 2/6] udmabuf: try udmabuf vmap test Huan Yang
2025-03-27  9:28 ` [RFC PATCH 3/6] mm/vmalloc: try add vmap folios range Huan Yang
2025-03-27  9:28 ` [RFC PATCH 4/6] udmabuf: use vmap_range_folios Huan Yang
2025-03-27  9:28 ` Huan Yang [this message]
2025-03-27  9:28 ` [RFC PATCH 6/6] udmabuf: remove no need code Huan Yang
2025-03-28 21:09 ` [RFC PATCH 0/6] Deep talk about folio vmap Vishal Moola (Oracle)
2025-04-04  9:01 ` CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP is broken, was " Christoph Hellwig
2025-04-04  9:38   ` Muchun Song
2025-04-04 10:07     ` Muchun Song
2025-04-07  1:59       ` Huan Yang
2025-04-07  2:57         ` Muchun Song
2025-04-07  3:21           ` Huan Yang
2025-04-07  3:37             ` Muchun Song
2025-04-07  6:43               ` Muchun Song
2025-04-07  7:09                 ` Huan Yang
2025-04-07  7:22                   ` Muchun Song
2025-04-07  8:55                     ` Huan Yang
2025-04-07  8:59                 ` Christoph Hellwig
2025-04-07  9:48                   ` Muchun Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250327092922.536-6-link@vivo.com \
    --to=link@vivo.com \
    --cc=akpm@linux-foundation.org \
    --cc=bingbu.cao@linux.intel.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@lst.de \
    --cc=kraxel@redhat.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=opensource.kernel@vivo.com \
    --cc=shuah@kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=urezki@gmail.com \
    --cc=vivek.kasireddy@intel.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox