From: Philipp Stanner <phasta@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>, Jens Axboe <axboe@kernel.dk>,
Bjorn Helgaas <bhelgaas@google.com>,
Mark Brown <broonie@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Philipp Stanner <pstanner@redhat.com>,
Damien Le Moal <dlemoal@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Yang Yingliang <yangyingliang@huawei.com>,
Zijun Hu <quic_zijuhu@quicinc.com>,
Hannes Reinecke <hare@suse.de>, Al Viro <viro@zeniv.linux.org.uk>,
Li Zetao <lizetao1@huawei.com>, Anuj Gupta <anuj20.g@samsung.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, linux-pci@vger.kernel.org,
Philipp Stanner <phasta@kernel.org>
Subject: [PATCH 1/2] mtip32xx: Remove unnecessary PCI function calls
Date: Thu, 27 Mar 2025 12:07:07 +0100 [thread overview]
Message-ID: <20250327110707.20025-3-phasta@kernel.org> (raw)
In-Reply-To: <20250327110707.20025-2-phasta@kernel.org>
pcim_iounmap_regions() is deprecated. Moreover, it is not necessary to
call it in the driver's remove() function or if probe() fails, since it
does cleanup automatically on driver detach.
Remove all calls to pcim_iounmap_regions().
Signed-off-by: Philipp Stanner <phasta@kernel.org>
---
drivers/block/mtip32xx/mtip32xx.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 95361099a2dc..63b9c41d3c25 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -3717,7 +3717,7 @@ static int mtip_pci_probe(struct pci_dev *pdev,
rv = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
if (rv) {
dev_warn(&pdev->dev, "64-bit DMA enable failed\n");
- goto setmask_err;
+ goto iomap_err;
}
/* Copy the info we may need later into the private data structure. */
@@ -3733,7 +3733,7 @@ static int mtip_pci_probe(struct pci_dev *pdev,
if (!dd->isr_workq) {
dev_warn(&pdev->dev, "Can't create wq %d\n", dd->instance);
rv = -ENOMEM;
- goto setmask_err;
+ goto iomap_err;
}
memset(cpu_list, 0, sizeof(cpu_list));
@@ -3830,8 +3830,6 @@ static int mtip_pci_probe(struct pci_dev *pdev,
drop_cpu(dd->work[1].cpu_binding);
drop_cpu(dd->work[2].cpu_binding);
}
-setmask_err:
- pcim_iounmap_regions(pdev, 1 << MTIP_ABAR);
iomap_err:
kfree(dd);
@@ -3907,7 +3905,6 @@ static void mtip_pci_remove(struct pci_dev *pdev)
pci_disable_msi(pdev);
- pcim_iounmap_regions(pdev, 1 << MTIP_ABAR);
pci_set_drvdata(pdev, NULL);
put_disk(dd->disk);
--
2.48.1
next prev parent reply other threads:[~2025-03-27 11:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 11:07 [PATCH 0/2] PCI: Remove pcim_iounmap_regions() Philipp Stanner
2025-03-27 11:07 ` Philipp Stanner [this message]
2025-03-27 11:33 ` [PATCH 1/2] mtip32xx: Remove unnecessary PCI function calls Mark Brown
2025-03-27 11:57 ` Jens Axboe
2025-03-27 11:07 ` [PATCH 2/2] PCI: Remove pcim_iounmap_regions() Philipp Stanner
2025-04-03 10:13 ` Zijun Hu
2025-03-27 11:42 ` [PATCH 0/2] " Andy Shevchenko
2025-04-02 7:58 ` Philipp Stanner
2025-04-02 13:53 ` Jonathan Cameron
2025-04-09 8:20 ` Philipp Stanner
2025-04-09 19:23 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250327110707.20025-3-phasta@kernel.org \
--to=phasta@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=pstanner@redhat.com \
--cc=quic_zijuhu@quicinc.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox