From: Jakub Kicinski <kuba@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
"H. Peter Anvin (Intel)" <hpa@zytor.com>,
Michael Kelley <mhklinux@outlook.com>,
"Xin Li (Intel)" <xin@zytor.com>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
Ingo Molnar <mingo@kernel.org>,
Nikolay Borisov <nik.borisov@suse.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [tip: x86/core] x86/cpufeatures: Generate the <asm/cpufeaturemasks.h> header based on build config
Date: Fri, 28 Mar 2025 17:56:06 -0700 [thread overview]
Message-ID: <20250328175606.5c7cc096@kernel.org> (raw)
In-Reply-To: <CAHk-=wi8h2fNpPBYakOMGhCk=pBSAQoLv=YG4KiTy45SZSQe7w@mail.gmail.com>
On Fri, 28 Mar 2025 17:22:03 -0700 Linus Torvalds wrote:
> > So I think the real fix is something like this ENTIRELY UNTESTED
> > patch. Whitespace-damaged again to make sure people don't apply this
> > mindlessly, it needs more thought:
>
> .. and that ended up being even more whitespace-damaged than I meant
> to make it, because it also line-wrapped.
>
> Oh well. Not pretty, but I hope people still get the idea.
>
> And I just actually tried doing a build after touching the .config
> file, and it did seem to work.
Excellent, can confirm that it works for me, too!
Thanks!!
> But since I had _also_ messed with the config file on purpose earlier,
> I'm not sure I'm actually testing the thing the networking builds
> trigger. So I might be entirely missing something.
FWIW the exact commands our build script uses are:
make W=1 LLVM=1 O=build_allmodconfig_cl -j 6 allmodconfig
./scripts/config --file build_allmodconfig_cl/.config -d werror -d kvm_werror -d drm_werror
make W=1 LLVM=1 O=build_allmodconfig_cl -j 6
next prev parent reply other threads:[~2025-03-29 0:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 18:47 [PATCH v7 0/4] x86/cpufeatures: Automatically generate required and disabled feature masks Xin Li (Intel)
2025-03-05 18:47 ` [PATCH v7 1/4] x86/cpufeatures: Add {required,disabled} feature configs Xin Li (Intel)
2025-03-05 18:47 ` [PATCH v7 2/4] x86/cpufeatures: Generate a feature mask header based on build config Xin Li (Intel)
2025-03-10 8:18 ` [tip: x86/cpu] x86/cpufeatures: Generate the <asm/cpufeaturemasks.h> " tip-bot2 for H. Peter Anvin (Intel)
2025-03-19 11:03 ` [tip: x86/core] " tip-bot2 for H. Peter Anvin (Intel)
2025-03-20 16:23 ` Michael Kelley
2025-03-20 16:56 ` Linus Torvalds
2025-03-23 18:06 ` Michael Kelley
2025-03-28 23:23 ` Jakub Kicinski
2025-03-29 0:14 ` Linus Torvalds
2025-03-29 0:22 ` Linus Torvalds
2025-03-29 0:56 ` Jakub Kicinski [this message]
2025-04-01 7:00 ` [PATCH] x86: don't re-generate cpufeaturemasks.h so eagerly Ingo Molnar
2025-03-29 0:56 ` [tip: x86/core] x86/cpufeatures: Generate the <asm/cpufeaturemasks.h> header based on build config H. Peter Anvin
2025-03-05 18:47 ` [PATCH v7 3/4] x86/cpufeatures: Remove {disabled,required}-features.h Xin Li (Intel)
2025-03-10 8:18 ` [tip: x86/cpu] " tip-bot2 for Xin Li (Intel)
2025-03-19 11:03 ` [tip: x86/core] " tip-bot2 for Xin Li (Intel)
2025-03-05 18:47 ` [PATCH v7 4/4] x86/cpufeatures: Use AWK to generate {REQUIRED|DISABLED}_MASK_BIT_SET Xin Li (Intel)
2025-03-07 18:28 ` [PATCH v7 0/4] x86/cpufeatures: Automatically generate required and disabled feature masks Xin Li
2025-03-07 19:18 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328175606.5c7cc096@kernel.org \
--to=kuba@kernel.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mhklinux@outlook.com \
--cc=mingo@kernel.org \
--cc=nik.borisov@suse.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox