Re: [PATCH v2 1/4] dt-bindings: net: Add MTIP L2 switch description

Krzysztof Kozlowski
2025-03-28T14:07:17Z

On 28/03/2025 14:35, Lukasz Majewski wrote:
> This patch provides description of the MTIP L2 switch available in some
> NXP's SOCs - e.g. imx287.
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
> Changes for v2:
> - Rename the file to match exactly the compatible
> (nxp,imx287-mtip-switch)

Please implement all the changes, not only the rename. I gave several
comments, although quick glance suggests you did implement them, so then
changelog is just incomplete.

> ---
> .../bindings/net/nxp,imx287-mtip-switch.yaml | 165 ++++++++++++++++++
> 1 file changed, 165 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml
> new file mode 100644
> index 000000000000..a3e0fe7783ec
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/nxp,imx287-mtip-switch.yaml
> @@ -0,0 +1,165 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/nxp,imx287-mtip-switch.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP SoC Ethernet Switch Controller (L2 MoreThanIP switch)
> +
> +maintainers:
> + - Lukasz Majewski <lukma@denx.de>
> +
> +description:
> + The 2-port switch ethernet subsystem provides ethernet packet (L2)
> + communication and can be configured as an ethernet switch. It provides the
> + reduced media independent interface (RMII), the management data input
> + output (MDIO) for physical layer device (PHY) management.
> +

If this is ethernet switch, why it does not reference ethernet-switch
schema? or dsa.yaml or dsa/ethernet-ports? I am not sure which one
should go here, but surprising to see none.

> +properties:
> + compatible:
> + const: nxp,imx287-mtip--switch

Just one -.

> +
> + reg:
> + maxItems: 1
> + description:
> + The physical base address and size of the MTIP L2 SW module IO range

Wasn't here, drop.

> +
> + phy-supply:
> + description:
> + Regulator that powers Ethernet PHYs.
> +
> + clocks:
> + items:
> + - description: Register accessing clock
> + - description: Bus access clock
> + - description: Output clock for external device - e.g. PHY source clock
> + - description: IEEE1588 timer clock
> +
> + clock-names:
> + items:
> + - const: ipg
> + - const: ahb
> + - const: enet_out
> + - const: ptp
> +
> + interrupts:
> + items:
> + - description: Switch interrupt
> + - description: ENET0 interrupt
> + - description: ENET1 interrupt
> +
> + pinctrl-names: true

Drop

> +
> + ethernet-ports:
> + type: object
> + additionalProperties: false
> +
> + properties:
> + '#address-cells':
> + const: 1
> + '#size-cells':
> + const: 0
> +
> + patternProperties:
> + "^port@[0-9]+$":

Keep consistent quotes, either " or '. Also [01]

> + type: object
> + description: MTIP L2 switch external ports
> +
> + $ref: ethernet-controller.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + items:
> + - enum: [1, 2]
> + description: MTIP L2 switch port number
> +
> + label:
> + description: Label associated with this port
> +
> + required:
> + - reg
> + - label
> + - phy-mode
> + - phy-handle
> +
> + mdio:
> + type: object
> + $ref: mdio.yaml#
> + unevaluatedProperties: false
> + description:
> + Specifies the mdio bus in the switch, used as a container for phy nodes.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts
> + - mdio
> + - ethernet-ports
> + - '#address-cells'
> + - '#size-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include<dt-bindings/interrupt-controller/irq.h>
> + switch@800f0000 {
> + compatible = "nxp,imx287-mtip-switch";
> + reg = <0x800f0000 0x20000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&mac0_pins_a>, <&mac1_pins_a>;
> + phy-supply = <&reg_fec_3v3>;
> + interrupts = <100>, <101>, <102>;
> + clocks = <&clks 57>, <&clks 57>, <&clks 64>, <&clks 35>;
> + clock-names = "ipg", "ahb", "enet_out", "ptp";
> + status = "okay";

Drop

> +
> + ethernet-ports {
> + #address-cells = <1>;
> + #size-cells = <0>;

Messed indentation. See example-schema or writing-schema.

Best regards,
Krzysztof