From: Andreas Kemnade <andreas@kemnade.info>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Tero Kristo <kristo@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: ti: Simplify ti_find_clock_provider()
Date: Mon, 31 Mar 2025 11:53:29 +0200 [thread overview]
Message-ID: <20250331115329.605ba522@akair> (raw)
In-Reply-To: <20250312163330.865573-2-robh@kernel.org>
Am Wed, 12 Mar 2025 11:33:30 -0500
schrieb "Rob Herring (Arm)" <robh@kernel.org>:
> Remove using for_each_of_allnodes_from() which is not safe to use
> without holding the DT spinlock. In reality that probably doesn't
> matter here. This is the only user in the whole tree, so it can be
> made private once removed here. The "from" argument is always NULL, so
> it can be dropped as well.
>
> There's a slight change in behavior in matching the "clock-output-names"
> value as the prior code would match if the node name matched the
> beginning of the value and the comparision was case insensitive. Now
> it must be an exact match.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Compiled only. I'm not sure if the the change in behavior is going to
> matter.
>
did some testing. Nothing odd seen at the platforms I tested but I feel
a bit uncomfortable with
https://lore.kernel.org/linux-clk/20240925100603.4cba9176@akair/
in combination with this.
Regards,
Andreas
next prev parent reply other threads:[~2025-03-31 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 16:33 [PATCH] clk: ti: Simplify ti_find_clock_provider() Rob Herring (Arm)
2025-03-31 9:53 ` Andreas Kemnade [this message]
2025-06-21 21:20 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331115329.605ba522@akair \
--to=andreas@kemnade.info \
--cc=kristo@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox