public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: srinivas.kandagatla@linaro.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/13] nvmem: patches (set 1) for 6.15
Date: Tue, 1 Apr 2025 20:18:51 +0100	[thread overview]
Message-ID: <2025040143-espionage-poison-2345@gregkh> (raw)
In-Reply-To: <20250309145703.12974-1-srinivas.kandagatla@linaro.org>

On Sun, Mar 09, 2025 at 02:56:50PM +0000, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> Hi Greg,
> 
> Here are few nvmem patches for 6.15, Could you queue
> these for 6.15.
> 
> patche include
> 	- updates to bindings to include MSM8960, X1E80100, MS8937,
> 	  IPQ5018
> 	- add support to bit offsets for register strides exceeding
> 	  single byte
> 	- add rockchip-otp variants.
> 	- Few enhancements in qfprom and rochchip nvmem providers.

Ok, I wanted to apply these, and tried to, but they fail horribly
because:

Commit: 1b14625bd6d4 ("nvmem: qfprom: switch to 4-byte aligned reads")
	Fixes tag: Fixes: 11ccaa312111 ("nvmem: core: verify cell's raw_len")
	Has these problem(s):
		- Target SHA1 does not exist
Commit: a8a7c7e34093 ("nvmem: core: update raw_len if the bit reading is required")
	Fixes tag: Fixes: 11ccaa312111 ("nvmem: core: verify cell's raw_len")
	Has these problem(s):
		- Target SHA1 does not exist
Commit: d44f60348d8c ("nvmem: core: fix bit offsets of more than one byte")
	Fixes tag: Fixes: 11ccaa312111 ("nvmem: core: verify cell's raw_len")
	Has these problem(s):
		- Target SHA1 does not exist

Why do we have 3 patches all fixing the original one here?  Why isn't
the original patch just "correct"?

And you can't send patches with git ids in them, that just doesn't work.

So please, go rework these to not introduce a bug and then fix it up,
that's just not ok when dealing with a patch series.

thanks,

greg k-h

  parent reply	other threads:[~2025-04-01 19:20 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-09 14:56 [PATCH v2 00/13] nvmem: patches (set 1) for 6.15 srinivas.kandagatla
2025-03-09 14:56 ` [PATCH v2 01/13] nvmem: rockchip-otp: Move read-offset into variant-data srinivas.kandagatla
2025-03-09 14:56 ` [PATCH v2 02/13] dt-bindings: nvmem: rockchip,otp: add missing limits for clock-names srinivas.kandagatla
2025-03-09 14:56 ` [PATCH v2 03/13] dt-bindings: nvmem: rockchip,otp: Add compatible for RK3576 srinivas.kandagatla
2025-03-09 14:56 ` [PATCH v2 04/13] nvmem: rockchip-otp: add rk3576 variant data srinivas.kandagatla
2025-03-09 14:56 ` [PATCH v2 05/13] dt-bindings: nvmem: qfprom: Add X1E80100 compatible srinivas.kandagatla
2025-03-09 14:56 ` [PATCH v2 06/13] dt-bindings: nvmem: Add compatible for MS8937 srinivas.kandagatla
2025-03-09 14:56 ` [PATCH v2 07/13] dt-bindings: nvmem: fixed-cell: increase bits start value to 31 srinivas.kandagatla
2025-03-09 14:56 ` [PATCH v2 08/13] nvmem: core: fix bit offsets of more than one byte srinivas.kandagatla
2025-03-09 14:56 ` [PATCH v2 09/13] nvmem: core: verify cell's raw_len srinivas.kandagatla
2025-03-09 14:57 ` [PATCH v2 10/13] nvmem: core: update raw_len if the bit reading is required srinivas.kandagatla
2025-03-09 14:57 ` [PATCH v2 11/13] nvmem: qfprom: switch to 4-byte aligned reads srinivas.kandagatla
2025-03-09 14:57 ` [PATCH v2 12/13] dt-bindings: nvmem: Add compatible for IPQ5018 srinivas.kandagatla
2025-03-09 14:57 ` [PATCH v2 13/13] dt-bindings: nvmem: Add compatible for MSM8960 srinivas.kandagatla
2025-03-25 11:31 ` [PATCH v2 00/13] nvmem: patches (set 1) for 6.15 Srinivas Kandagatla
2025-03-30 18:30   ` Greg KH
2025-03-30 21:03     ` Srinivas Kandagatla
2025-03-31  4:04       ` Greg KH
2025-04-01 19:18 ` Greg KH [this message]
2025-04-02  8:19   ` Srinivas Kandagatla
2025-04-02 11:31     ` Greg KH
2025-04-03  9:18       ` Srinivas Kandagatla
2025-04-03  9:25         ` Dmitry Baryshkov
2025-04-03  9:27           ` Srinivas Kandagatla
2025-04-03  9:31             ` Dmitry Baryshkov
2025-04-03  9:35               ` Srinivas Kandagatla
2025-04-03  9:38                 ` Dmitry Baryshkov
2025-04-03 13:52                   ` Greg KH
2025-04-03 13:58                     ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025040143-espionage-poison-2345@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox