From: Jason Gunthorpe <jgg@nvidia.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Dave Airlie <airlied@gmail.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] drm for 6.15-rc1
Date: Wed, 2 Apr 2025 10:03:47 -0300 [thread overview]
Message-ID: <20250402130347.GB342109@nvidia.com> (raw)
In-Reply-To: <87v7rm203e.fsf@intel.com>
On Wed, Apr 02, 2025 at 03:56:37PM +0300, Jani Nikula wrote:
> On Tue, 01 Apr 2025, Jason Gunthorpe <jgg@nvidia.com> wrote:
> > On Tue, Apr 01, 2025 at 10:42:35PM +0300, Jani Nikula wrote:
> >> On Tue, 01 Apr 2025, Jason Gunthorpe <jgg@nvidia.com> wrote:
> >> > So, I'd suggest a better way to run this is first build the kernel,
> >> > then mine the gcc -MD output (ie stored in the .XX.cmd files) to
> >> > generate a list of headers that are actually part of the build, then
> >> > only test those. That eliminates all the kconfig problems. Opt out any
> >> > special headers that really have a good reason not to be stand alone.
> >>
> >> I think we'd want the drm headers pass the checks independent of configs
> >> (apart from CONFIG_DRM). One size doesn't fit all.
> >
> > Why? That demand is just making it impossible to make shared
> > infrastructure, and I don't think DRM should go off and build its own
> > stuff just for DRM in a way that nobody else can use it.
> >
> > If you really, really, care then you can have your makefile codegen an
> > "allheaders.c" that #includes drm/*.h and compile that.
>
> The v2 series [1] generalizes the header checks and it's no longer in
> any way dependent on DRM. For starters, each subsystem/driver needs to
> decide for themselves which headers are to be checked.
Yuk. The idea at the top of this email is alot better. Why don't you
implement it?
> This can be expanded with more clever ways to choose the headers to
> check. But we have to start *somewhere*.
Bah, that argument only works if nobody has better ideas. There are
meaningful technical problems with your approach, and proposed
solutions here.
Jason
next prev parent reply other threads:[~2025-04-02 13:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 2:53 [git pull] drm for 6.15-rc1 Dave Airlie
2025-03-29 0:47 ` Linus Torvalds
2025-03-31 10:17 ` Jani Nikula
2025-03-31 11:03 ` Simona Vetter
2025-03-31 13:31 ` Jason Gunthorpe
2025-04-01 12:21 ` Jani Nikula
2025-04-01 16:12 ` Linus Torvalds
2025-04-01 18:46 ` Masahiro Yamada
2025-04-01 19:14 ` Jason Gunthorpe
2025-04-01 19:36 ` Masahiro Yamada
2025-04-01 19:42 ` Jani Nikula
2025-04-01 19:46 ` Jason Gunthorpe
2025-04-02 12:56 ` Jani Nikula
2025-04-02 13:03 ` Jason Gunthorpe [this message]
2025-04-02 13:53 ` Jani Nikula
2025-04-02 14:41 ` Simona Vetter
2025-04-02 16:34 ` Jason Gunthorpe
2025-04-01 19:28 ` Jani Nikula
2025-03-31 15:42 ` Linus Torvalds
2025-04-01 12:34 ` Jani Nikula
2025-03-29 1:01 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402130347.GB342109@nvidia.com \
--to=jgg@nvidia.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox