public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Dave Airlie <airlied@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] drm for 6.15-rc1
Date: Wed, 2 Apr 2025 13:34:02 -0300	[thread overview]
Message-ID: <20250402163402.GD342109@nvidia.com> (raw)
In-Reply-To: <Z-1MqJen5o0yhoQQ@phenom.ffwll.local>

On Wed, Apr 02, 2025 at 04:41:44PM +0200, Simona Vetter wrote:

> - Gradually roll this out, ideally with support in main Kbuild so it
>   doesn't have to be replicated.

No one said flag day, you'd have to approach the same way everyone
else has done when adding new compiler errors and warnings to the
build. An off-by-default option to produce the new errors/warnings,
and alot of time and fixes before the new tests become on by default.

The stuff like this is not really sensible:

+header-check-$(CONFIG_DRM_I915_WERROR) += \
+       $(filter-out $(no-header-test),$(shell cd $(src) && find * -name '*.h'))

Not only should we not be using globs to read the source files in a
build system, but it is brutal to have to list every header file in
the build in the makefiles, along with some kconfig :\

( also find is usually spelled $(wildcard $(src)/*.h) )

Jason

  reply	other threads:[~2025-04-02 16:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28  2:53 [git pull] drm for 6.15-rc1 Dave Airlie
2025-03-29  0:47 ` Linus Torvalds
2025-03-31 10:17   ` Jani Nikula
2025-03-31 11:03     ` Simona Vetter
2025-03-31 13:31       ` Jason Gunthorpe
2025-04-01 12:21         ` Jani Nikula
2025-04-01 16:12           ` Linus Torvalds
2025-04-01 18:46             ` Masahiro Yamada
2025-04-01 19:14               ` Jason Gunthorpe
2025-04-01 19:36                 ` Masahiro Yamada
2025-04-01 19:42                 ` Jani Nikula
2025-04-01 19:46                   ` Jason Gunthorpe
2025-04-02 12:56                     ` Jani Nikula
2025-04-02 13:03                       ` Jason Gunthorpe
2025-04-02 13:53                         ` Jani Nikula
2025-04-02 14:41                           ` Simona Vetter
2025-04-02 16:34                             ` Jason Gunthorpe [this message]
2025-04-01 19:28               ` Jani Nikula
2025-03-31 15:42     ` Linus Torvalds
2025-04-01 12:34       ` Jani Nikula
2025-03-29  1:01 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250402163402.GD342109@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox