Re: [PATCH net 4/7] net: hibmcge: fix wrong mtu log issue

Simon Horman
2025-04-02T18:58:18Z

On Wed, Apr 02, 2025 at 09:39:02PM +0800, Jijie Shao wrote:
> A dbg log is generated when the driver modifies the MTU,
> which is expected to trace the change of the MTU.
>
> However, the log is recorded after WRITE_ONCE().
> At this time, netdev->mtu has been changed to the new value.
> As a result, netdev->mtu is the same as new_mtu.
>
> This patch modifies the log location and records logs before WRITE_ONCE().
>
> Fixes: ff4edac6e9bd ("net: hibmcge: Implement some .ndo functions")
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>