Re: [PATCH v2 2/2] ARM: dts: omap4: panda: cleanup bluetooth

[Andreas Kemnade <andreas@kemnade.info>]

Am Wed, 2 Apr 2025 14:54:12 +0300
schrieb Roger Quadros <rogerq@kernel.org>:

> Hi Andreas,
> 
> On 30/03/2025 18:14, Andreas Kemnade wrote:
> > Bluetooth is available on the other Panda board versions, too, so move
> > stuff to common and specify the needed clock properly.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> >  .../boot/dts/ti/omap/omap4-panda-common.dtsi  | 31 ++++++++++++++++--
> >  arch/arm/boot/dts/ti/omap/omap4-panda-es.dts  | 32 -------------------
> >  2 files changed, 28 insertions(+), 35 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> > index c860b590142a..05c871d31d7b 100644
> > --- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> > +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> > @@ -367,10 +367,8 @@ OMAP4_IOPAD(0x130, PIN_INPUT_PULLUP | MUX_MODE0)	/* i2c4_sda */
> >  	 */
> >  	wl12xx_gpio: wl12xx-gpio-pins {
> >  		pinctrl-single,pins = <
> > -			OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3)		/* gpmc_a19.gpio_43 */
> > -			OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3)		/* gpmc_a22.gpio_46 */
> > +			OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3)		/* gpmc_a19.gpio_43 - WLAN_EN */
> >  			OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3)	/* gpmc_a24.gpio_48 */  
> 
> Apparently GPIO 48 is FM audio related and has nothing to do with wl12xx?
> So should we drop it from here?
> 
Well, FM audio is part of the wl12xx, so it is a bit related. There is
no driver for the FM part upstream. It is a bit suboptimal, so feel
free to submit a patch to put it somewhere else.

Regards,
Andreas