From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 732A224113A for ; Thu, 3 Apr 2025 07:43:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743666221; cv=none; b=ZDi6iJVwK/XyTNPEXFNlycAfeP6ipTya8CxAOC2BcYauhbPt6ojAzxUv6LFzhvAqqD66NhOsLXSk1Nz6o7nZIygqaRIojsOlBgXjPsTk7clBYHTB88VE/K+jjS33nds9u2970hRolTPinP7cT0bEU5o2gfkOV3PHAICzJKEJTK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743666221; c=relaxed/simple; bh=vib5eqL8Yk6nv7cYTs50OyikP7l3XdHYId6taSeO3OM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MSprIEAInufbLmn4U3fJQQXOgreOctqCKGBJ+8uMbGSfsAGtfJQ0Gbxr7UGsP3MOj+UjZgtrDlCEG730KbIXqYX1+ie+v/qrOIcBWsLqL0XkUUoDSkjvYiPbYz2krlCGiy3WKKaUlaoxT7Q7t+B0rvGHDtcMdxIpKyBNPGPZdto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AJwplS2V; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AJwplS2V" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743666218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NuIGPILwX0KGwdKCW254FLXrK5Uw6+p9BSYPzhYokBA=; b=AJwplS2VcgKpYT0zc34MVr8tWO9edyornnfd6a2s7qo6VF45XLjCxgEURYsd8IliiaYfJ5 mtWKYMl9iVCTZZirnLCb+7jiiyL5IfAAI2CM7laUNB2+Q+PlewI388ef6CN0CzRAn6BZvb ty5Y5796fYAJJdJehz9W9xKUQxchvaI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-60-ymyfZV12NvOE8JYK7UGCWQ-1; Thu, 03 Apr 2025 03:43:37 -0400 X-MC-Unique: ymyfZV12NvOE8JYK7UGCWQ-1 X-Mimecast-MFC-AGG-ID: ymyfZV12NvOE8JYK7UGCWQ_1743666216 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d734da1a3so3012275e9.0 for ; Thu, 03 Apr 2025 00:43:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743666216; x=1744271016; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NuIGPILwX0KGwdKCW254FLXrK5Uw6+p9BSYPzhYokBA=; b=gHCJUkwzU6Q0uC27bRhU69BTmS4CWzDQbAK/84DCxCCyTC5LDWmv7M99C5QBqMMGMU 6mgfbnAvgrB6KhqxeSMy2isHcR8lml+7/bdOmrc7d8pyv8q/hgwPovD77hnI/SRl8J+N WcLVBp3dS0Ou3bjHcOAcYOcwMW8rAl46k7/N55Wv2KCd+OOg3VSCukc4BLTbwd73PwBC cXPjv0Clu5W4rxTLeyFuBlS6X45Ul4lIrx1Of2dQ9y/lHzFbCBS8qR9UDTdGlQawW5MY gvXwuLXTTBB5viY+IzYr8dhMSMALHyYDo/+YmZHp9EvurhOaQYB+Uph0E+3CmN51uAdp 72Qg== X-Forwarded-Encrypted: i=1; AJvYcCVREoMdT7HLttxjQ+THGsKBOckrUudRXH69567n7Mj5ztWSlSihgZDIKdf1yIZnghggn9qA49EhlZKbUa8=@vger.kernel.org X-Gm-Message-State: AOJu0YzYykor4rZLO4MUuS7YVGkRqQC7+wAO2jlaCcnAkReVo1icGg01 J4n7ZVdg4uKTB0GVScyY83p94ztG97oenL5ortr8p8XCuvnj08Q7GZH7inxQmFH8ceugfSI3Qhg 9i09LSoLhbqIugrxF/JV5dJ8oNSKEC8D76i6APH7jTRp5kjn8AqIH9hNoM3MM8w== X-Gm-Gg: ASbGnctIeRE8USb4FX4fyGqs2vLnt0qFVccxOIYx1d6tKc4OszcdfPAdlmckhOfgxOi VAYPH5+M7WUlqnyB2qI86KegveGmQTNb4RPZMreNNW+ugkzO67MFqvqtdqRJqODEMC/qM5XtXN0 rUXeioCDNiFU/RaAVVWb/SSmLyCMAxGWmgTZOB4eg7Zy/Kc5fcYzDmA4Mq7qak51bLkY1Rf2zOS /KHK/XcGrkGQyik0e2M5Xakdfz85dZoBWVWtW5Z9cNThvR6atC8KmgpRPk/2hrnm6xlRHqXm0Og tqUyEfL8/g== X-Received: by 2002:a5d:6d8a:0:b0:38f:3224:65ff with SMTP id ffacd0b85a97d-39c2f8c6303mr1147208f8f.5.1743666215772; Thu, 03 Apr 2025 00:43:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKHA+wdnxQEWeLGPaea4xtTaMDclvnSmU451MGtx5swswXpr4ijH+EFOoCDWUx1yGDtMAEng== X-Received: by 2002:a5d:6d8a:0:b0:38f:3224:65ff with SMTP id ffacd0b85a97d-39c2f8c6303mr1147183f8f.5.1743666215393; Thu, 03 Apr 2025 00:43:35 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:1517:1000:ea83:8e5f:3302:3575]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301b6321sm1001079f8f.44.2025.04.03.00.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 00:43:34 -0700 (PDT) Date: Thu, 3 Apr 2025 03:43:31 -0400 From: "Michael S. Tsirkin" To: Christoph Hellwig Cc: David Woodhouse , virtio-comment@lists.linux.dev, Claire Chang , linux-devicetree , Rob Herring , =?iso-8859-1?Q?J=F6rg?= Roedel , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, graf@amazon.de Subject: Re: [RFC PATCH 1/3] content: Add VIRTIO_F_SWIOTLB to negotiate use of SWIOTLB bounce buffers Message-ID: <20250403034143-mutt-send-email-mst@kernel.org> References: <19ba662feeb93157bc8a03fb0b11cb5f2eca5e40.camel@infradead.org> <20250402111901-mutt-send-email-mst@kernel.org> <6b3b047f1650d91abe5e523dd7f862c6f7ee6611.camel@infradead.org> <20250402114757-mutt-send-email-mst@kernel.org> <965ccf2f972c5d5f1f4edacb227f03171f20e887.camel@infradead.org> <20250402124131-mutt-send-email-mst@kernel.org> <06465bcf4422d088df2a0ce9cdb09767dac83118.camel@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 03, 2025 at 12:39:39AM -0700, Christoph Hellwig wrote: > On Thu, Apr 03, 2025 at 08:37:20AM +0100, David Woodhouse wrote: > > Hm. I was just trying to point out what seemed obvious, that when a PCI > > device does 'DMA' to an address region which is actually within one of > > its *own* BARs, > > PCIe devices can't do DMA to their own BARs by definition, see the route > to self rule. > > Pretending that they do it by parsing the addresses is bound to fail > because the addresses seen by the driver and the device can be > different. > > NVMe got this wrong not just once but twice and is still suffering from > this misunderstanding. If you want to enhance a protocol to support > addressing a local indirection buffer do not treat it as fake DMA > but rather use explicit addressing for it, or you will be in a world of > trouble. Hm. This is what this proposal does, indeed. Can be changed though - since all accesses are now within the SWIOTLB, they can be treated as offsets instead. -- MST