From: Arnd Bergmann <arnd@kernel.org>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Jani Nikula" <jani.nikula@intel.com>,
"Christian König" <christian.koenig@amd.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
"Maher Sanalla" <msanalla@nvidia.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] RDMA/hfi1: use a struct group to avoid warning
Date: Thu, 3 Apr 2025 16:47:53 +0200 [thread overview]
Message-ID: <20250403144801.3779379-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
On gcc-11 and earlier, the driver sometimes produces a warning
for memset:
In file included from include/linux/string.h:392,
from drivers/infiniband/hw/hfi1/mad.c:6:
In function 'fortify_memset_chk',
inlined from '__subn_get_opa_hfi1_cong_log' at drivers/infiniband/hw/hfi1/mad.c:3873:2,
inlined from 'subn_get_opa_sma' at drivers/infiniband/hw/hfi1/mad.c:4114:9:
include/linux/fortify-string.h:480:4: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror]
__write_overflow_field(p_size_field, size);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This seems to be a false positive, and I found no nice way to rewrite
the code to avoid the warning, but adding a a struct group works.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/infiniband/hw/hfi1/hfi.h | 6 ++++--
drivers/infiniband/hw/hfi1/mad.c | 4 ++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/hfi1/hfi.h b/drivers/infiniband/hw/hfi1/hfi.h
index cb630551cf1a..fca37eb167cc 100644
--- a/drivers/infiniband/hw/hfi1/hfi.h
+++ b/drivers/infiniband/hw/hfi1/hfi.h
@@ -883,8 +883,10 @@ struct hfi1_pportdata {
* cc_log_lock protects all congestion log related data
*/
spinlock_t cc_log_lock ____cacheline_aligned_in_smp;
- u8 threshold_cong_event_map[OPA_MAX_SLS / 8];
- u16 threshold_event_counter;
+ struct_group (zero_event_map,
+ u8 threshold_cong_event_map[OPA_MAX_SLS / 8];
+ u16 threshold_event_counter;
+ );
struct opa_hfi1_cong_log_event_internal cc_events[OPA_CONG_LOG_ELEMS];
int cc_log_idx; /* index for logging events */
int cc_mad_idx; /* index for reporting events */
diff --git a/drivers/infiniband/hw/hfi1/mad.c b/drivers/infiniband/hw/hfi1/mad.c
index b39f63ce6dfc..0dea8d01e868 100644
--- a/drivers/infiniband/hw/hfi1/mad.c
+++ b/drivers/infiniband/hw/hfi1/mad.c
@@ -3870,8 +3870,8 @@ static int __subn_get_opa_hfi1_cong_log(struct opa_smp *smp, u32 am,
* Reset threshold_cong_event_map, and threshold_event_counter
* to 0 when log is read.
*/
- memset(ppd->threshold_cong_event_map, 0x0,
- sizeof(ppd->threshold_cong_event_map));
+ memset(&ppd->zero_event_map, 0x0,
+ sizeof(ppd->zero_event_map));
ppd->threshold_event_counter = 0;
spin_unlock_irq(&ppd->cc_log_lock);
--
2.39.5
next reply other threads:[~2025-04-03 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 14:47 Arnd Bergmann [this message]
2025-04-07 18:27 ` [PATCH] RDMA/hfi1: use a struct group to avoid warning Jason Gunthorpe
2025-04-08 12:40 ` Arnd Bergmann
2025-04-10 7:59 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403144801.3779379-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=christian.koenig@amd.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jani.nikula@intel.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@treblig.org \
--cc=msanalla@nvidia.com \
--cc=rostedt@goodmis.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox