Re: [PATCH v2 0/6] gpiolib: acpi: Refactor to shrink the code by ~8%

Andy Shevchenko
2025-04-07T06:41:47Z

On Fri, Apr 04, 2025 at 07:43:18AM +0300, Mika Westerberg wrote:
> On Thu, Apr 03, 2025 at 06:59:11PM +0300, Andy Shevchenko wrote:
> > A simple refactoring of the GPIO ACPI library parts to get an impressive
> > ~8% code shrink on x86_64 and ~2% on x86_32. Also reduces a C code a bit.
> >
> > add/remove: 0/2 grow/shrink: 0/5 up/down: 0/-1221 (-1221)
> > Function old new delta
> > acpi_gpio_property_lookup 425 414 -11
> > acpi_find_gpio.__UNIQUE_ID_ddebug478 56 - -56
> > acpi_dev_gpio_irq_wake_get_by.__UNIQUE_ID_ddebug480 56 - -56
> > acpi_find_gpio 354 216 -138
> > acpi_get_gpiod_by_index 462 307 -155
> > __acpi_find_gpio 877 638 -239
> > acpi_dev_gpio_irq_wake_get_by 695 129 -566
> > Total: Before=15375, After=14154, chg -7.94%

> Looks good now,
>
> Acked-by: Mika Westerberg <westeri@kernel.org>

Pushed to my review and testing queue, thanks!

--
With Best Regards,
Andy Shevchenko