From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C46FB27CCF7; Thu, 3 Apr 2025 19:07:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743707271; cv=none; b=aRznkSkg31LPWKA0/AOLDd0FMDmtIDd+d1qt2VT3ezXvgoIxQCJit4frDG6rw+L5LKHhzWIadT5VrsKlEQdWWBFBQ5XqdN3P1SEXIDMkqHiX3U5CthZ0y5LLBz97I8CMtIaKmcw4smeS5KIlp6ZBl/jjytWbZ0wK2dS7V+9Y2us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743707271; c=relaxed/simple; bh=Uod12YOpHwXDSMRHEIb0XSjBOKoLLyNPXRB30S/B5uk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KjD+1zXNS2gznua3JgGMlvOffwMhZE1iyK/L9Is5rlvfossUt5EFLVZdsOsbvFfj+Tgr4M1aI7NjVzsLRpcz+nY7ji0pNRFiLYLcMuTROHX39+1C0UHHr3rc1q8eF4rrTGIb930XzUTNu8cPYEgugJj6wUCcMSJIBilRjKhbck4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lA8SU3pY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lA8SU3pY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDCF6C4CEE8; Thu, 3 Apr 2025 19:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743707271; bh=Uod12YOpHwXDSMRHEIb0XSjBOKoLLyNPXRB30S/B5uk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lA8SU3pY3KfhqirmBPtEOGnrxh4e2WHh7XWPBDw8xw03g0F9jHGm4wpRhdfff1UON RNIkW7GTooT7c+COKnjhC0XIvSn59FRMGNe1udMrBDXh2avO1m/xSyQUuL0GGChufs EzpyT3zDkOwbPnQCHNmDaQeJ4yN5NiKyz/YrOyytaJ+5z4R8ZCjQ1kjAVlhNsjiTna T6GSRg+ROzgABFMfQWgNtUGfPzJ26XBGldtuwlzuHsgF51lkd2vaXCdPe8ub7H6XSF ja3ybIIrp7jjfJp2ZKAfi1wr9AJyKwE4dmL5BUTIfsUo8svBQOxWD/xdbRuCRxTNaR ePeF3d7PxkG3w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chao Yu , Jaegeuk Kim , Sasha Levin , linux-f2fs-devel@lists.sourceforge.net Subject: [PATCH AUTOSEL 6.6 02/26] f2fs: don't retry IO for corrupted data scenario Date: Thu, 3 Apr 2025 15:07:21 -0400 Message-Id: <20250403190745.2677620-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250403190745.2677620-1-sashal@kernel.org> References: <20250403190745.2677620-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.85 Content-Transfer-Encoding: 8bit From: Chao Yu [ Upstream commit 1534747d3170646ddeb9ea5f7caaac90359707cf ] F2FS-fs (dm-105): inconsistent node block, nid:430, node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:2125070942] F2FS-fs (dm-105): inconsistent node block, nid:430, node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:2125070942] F2FS-fs (dm-105): inconsistent node block, nid:430, node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:2125070942] F2FS-fs (dm-105): inconsistent node block, nid:430, node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:2125070942] F2FS-fs (dm-105): inconsistent node block, nid:430, node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:2125070942] F2FS-fs (dm-105): inconsistent node block, nid:430, node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:2125070942] F2FS-fs (dm-105): inconsistent node block, nid:430, node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:2125070942] F2FS-fs (dm-105): inconsistent node block, nid:430, node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:2125070942] F2FS-fs (dm-105): inconsistent node block, nid:430, node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:2125070942] F2FS-fs (dm-105): inconsistent node block, nid:430, node_footer[nid:2198964142,ino:598252782,ofs:118300154,cpver:5409237455940746069,blkaddr:2125070942] If node block is loaded successfully, but its content is inconsistent, it doesn't need to retry IO. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/inode.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 7ad4a92417591..173832fd0168e 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -764,8 +764,12 @@ void f2fs_update_inode_page(struct inode *inode) if (err == -ENOENT) return; + if (err == -EFSCORRUPTED) + goto stop_checkpoint; + if (err == -ENOMEM || ++count <= DEFAULT_RETRY_IO_COUNT) goto retry; +stop_checkpoint: f2fs_stop_checkpoint(sbi, false, STOP_CP_REASON_UPDATE_INODE); return; } -- 2.39.5