From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89C012BF3F7; Thu, 3 Apr 2025 19:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743707420; cv=none; b=Mn+A8PaTcP//bEy5uyNR155tI66XN06ZuLEECEurzM6Z/Le/mZMqvJjyk4vcz0OnkAoo4F8aPw4kbE4Q0YKTgwXIHK5Dv7A1tkDyJdkZwnetg/DbU8FnXdlF+5qzIdoxFuniTNBgG7fEWqV04LkfXICyG3QDTxQeLa1nDedmRjo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743707420; c=relaxed/simple; bh=jH5R9cifouU2hQPN0mHbfNCoL5kY/EOskBIc+Lz+dIc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ef5j8mbSJaFd0U/qg53LBPMll7J5Z6+0v03PBrxbJwOqACJ/gSyeNv4WqFyA00g3efT8gEQ9CdttyitoCgMYKyKhPXCjPHdOirmbrGHRzDpgBUM34reT/HviKsJZefkA6VopkhUN8uh6kNJPJPP6XKc/F9cgvUY/xyl4ckx1oJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PTEOPOTE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PTEOPOTE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B819C4CEE3; Thu, 3 Apr 2025 19:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743707420; bh=jH5R9cifouU2hQPN0mHbfNCoL5kY/EOskBIc+Lz+dIc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PTEOPOTEIESPWH+IquY5LDGn1Xr8tTZty7jH4hKulRaO18pvCdcdDoctC0V7YkXPH 3WDC82gGA+BHbADOoloh1O+oVpZOI2pGNC4gfOQaujKJZBLp7dxYE0FBmgmJDdzWAa euy1NnfRTSaBlaAv8WTz7rKkC6+rI8peYd3ObgUIfiYdEjlplCFC4Qopqr2A9J9RD3 pFi7MpKf9JuEBpkMX0R3kO4sgxch3k8GtNxWQBUg/63+/mXq/BtW+8DDskkj4yG3Hq hFTV69L5j5gey5ySizX0GeN+Nj+tT50tqOewWLFg54eSL7kBLxedwHjB7Ma8u15jAS jaIVSVBTrEJ2A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Niklas Cassel , Philip Pemberton , Damien Le Moal , Sasha Levin , linux-ide@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 06/15] ata: libata-eh: Do not use ATAPI DMA for a device limited to PIO mode Date: Thu, 3 Apr 2025 15:09:53 -0400 Message-Id: <20250403191002.2678588-6-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250403191002.2678588-1-sashal@kernel.org> References: <20250403191002.2678588-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.235 Content-Transfer-Encoding: 8bit From: Niklas Cassel [ Upstream commit 91ec84f8eaddbc93d7c62e363d68aeb7b89879c7 ] atapi_eh_request_sense() currently uses ATAPI DMA if the SATA controller has ATA_FLAG_PIO_DMA (PIO cmds via DMA) set. However, ATA_FLAG_PIO_DMA is a flag that can be set by a low-level driver on a port at initialization time, before any devices are scanned. If a controller detects a connected device that only supports PIO, we set the flag ATA_DFLAG_PIO. Modify atapi_eh_request_sense() to not use ATAPI DMA if the connected device only supports PIO. Reported-by: Philip Pemberton Closes: https://lore.kernel.org/linux-ide/c6722ee8-5e21-4169-af59-cbbae9edc02f@philpem.me.uk/ Tested-by: Philip Pemberton Reviewed-by: Damien Le Moal Link: https://lore.kernel.org/r/20250221015422.20687-2-cassel@kernel.org Signed-off-by: Niklas Cassel Signed-off-by: Sasha Levin --- drivers/ata/libata-eh.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index 48130b2543966..e700024a8b482 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -1479,8 +1479,15 @@ unsigned int atapi_eh_request_sense(struct ata_device *dev, tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE; tf.command = ATA_CMD_PACKET; - /* is it pointless to prefer PIO for "safety reasons"? */ - if (ap->flags & ATA_FLAG_PIO_DMA) { + /* + * Do not use DMA if the connected device only supports PIO, even if the + * port prefers PIO commands via DMA. + * + * Ideally, we should call atapi_check_dma() to check if it is safe for + * the LLD to use DMA for REQUEST_SENSE, but we don't have a qc. + * Since we can't check the command, perhaps we should only use pio? + */ + if ((ap->flags & ATA_FLAG_PIO_DMA) && !(dev->flags & ATA_DFLAG_PIO)) { tf.protocol = ATAPI_PROT_DMA; tf.feature |= ATAPI_PKT_DMA; } else { -- 2.39.5