public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Raag Jadav <raag.jadav@intel.com>
Cc: david.m.ertman@intel.com, ira.weiny@intel.com, lee@kernel.org,
	andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] mfd: core: Support auxiliary device
Date: Thu, 3 Apr 2025 15:02:47 +0100	[thread overview]
Message-ID: <2025040336-ethically-regulate-3594@gregkh> (raw)
In-Reply-To: <20250403110053.1274521-1-raag.jadav@intel.com>

On Thu, Apr 03, 2025 at 04:30:53PM +0530, Raag Jadav wrote:
> Extend MFD subsystem to support auxiliary child device. This is useful for
> MFD usecases where parent device is on a discoverable bus and doesn't fit
> into the platform device criteria. Current support is limited to just PCI
> devices, but this can be further extended to support other types like USB
> in the future.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
> 
> I've been cooking this on my spare time during merge window. I'm not
> very confident about this but thought I'd share it. It might be
> controversial since I stole quite a bit from platform infrastructure,
> so please consider this an RFC and let's discuss how to approach this.
> 
> More discussion at [*].
> [*] https://lore.kernel.org/r/2025032609-query-limit-491b@gregkh
> 
> A few things that are still open,
> 
> 1. Since we're doing it for PCI devices (Greg's recommendation), how do
>    we force the existing ones to use their original platform path?

That's up to you all, but I wouldn't recommend forcing everything to
change for existing drivers.  So make it "opt-in" somehow?  I would love
to make it change for existing drivers, but I don't know what that might
break (it _should_ not break anything, but we've already found breakages
when moving some platform devices over to other busses like faux due to
bugs in userspace scripts.)

> 2. Should we allow auxiliary drivers to manage their own resources
>    (MEM, IO, IRQ etc)?

The resources are all shared by the "parent" device, that's what makes
aux drivers work, they need to handle this as there is no unique way to
carve up the resources here.

So I don't know how you would do this, sorry.

thanks,

greg k-h

  reply	other threads:[~2025-04-03 14:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03 11:00 [PATCH v1] mfd: core: Support auxiliary device Raag Jadav
2025-04-03 14:02 ` Greg KH [this message]
2025-04-03 14:16   ` Andy Shevchenko
2025-04-03 14:19     ` Andy Shevchenko
2025-04-03 14:23       ` Greg KH
2025-04-03 14:26         ` Andy Shevchenko
2025-04-03 14:31           ` Raag Jadav
2025-04-04 11:36   ` Raag Jadav
2025-04-04 12:29     ` Andy Shevchenko
2025-04-04 12:35       ` Raag Jadav
2025-04-04 13:00         ` Andy Shevchenko
2025-04-04 13:39           ` Raag Jadav
2025-04-04 13:56             ` Andy Shevchenko
2025-04-04 14:47               ` Raag Jadav
2025-04-03 15:11 ` kernel test robot
2025-04-03 15:11 ` kernel test robot
2025-04-03 21:39 ` kernel test robot
2025-04-04 15:35 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025040336-ethically-regulate-3594@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=david.m.ertman@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raag.jadav@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox