From: Qing Wong <wangqing7171@gmail.com>
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Qing Wang <wangqing7171@gmail.com>
Subject: [PATCH 1/2] Revert "perf/core: Fix hardlockup failure caused by perf throttle"
Date: Sat, 5 Apr 2025 22:16:34 +0800 [thread overview]
Message-ID: <20250405141635.243786-2-wangqing7171@gmail.com> (raw)
In-Reply-To: <20250405141635.243786-1-wangqing7171@gmail.com>
From: Qing Wang <wangqing7171@gmail.com>
This reverts commit 15def34e2635ab7e0e96f1bc32e1b69609f14942.
The hardlockup failure does not exist because:
1. The hardlockup's watchdog event is a pinned event, which exclusively
occupies a dedicated PMC (Performance Monitoring Counter) and is unaffected
by PMC scheduling.
2. The hardware event throttling mechanism only disables the specific PMC
where throttling occurs, without impacting other PMCs. Consequently, The
hardlockup event's dedicated PMC remains entirely unaffected.
Signed-off-by: Qing Wang <wangqing7171@gmail.com>
---
kernel/events/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 0bb21659e252..29cdb240e104 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -10049,8 +10049,8 @@ __perf_event_account_interrupt(struct perf_event *event, int throttle)
hwc->interrupts = 1;
} else {
hwc->interrupts++;
- if (unlikely(throttle &&
- hwc->interrupts > max_samples_per_tick)) {
+ if (unlikely(throttle
+ && hwc->interrupts >= max_samples_per_tick)) {
__this_cpu_inc(perf_throttled_count);
tick_dep_set_cpu(smp_processor_id(), TICK_DEP_BIT_PERF_EVENTS);
hwc->interrupts = MAX_INTERRUPTS;
--
2.43.0
next prev parent reply other threads:[~2025-04-05 14:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-05 14:16 [PATCH 0/2] perf/core: Fix broken throttling bugs Qing Wong
2025-04-05 14:16 ` Qing Wong [this message]
2025-04-18 8:57 ` [PATCH 1/2] Revert "perf/core: Fix hardlockup failure caused by perf throttle" Peter Zijlstra
2025-04-05 14:16 ` [PATCH 2/2] perf/core: Fix broken throttling when max_samples_per_tick=1 Qing Wong
2025-04-18 9:03 ` Peter Zijlstra
2025-04-18 13:08 ` Qing Wang
2025-04-18 13:10 ` Peter Zijlstra
2025-04-18 13:19 ` Qing Wang
2025-04-30 11:58 ` [tip: perf/core] " tip-bot2 for Qing Wang
2025-04-15 14:22 ` [PATCH 0/2] perf/core: Fix broken throttling bugs Qing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250405141635.243786-2-wangqing7171@gmail.com \
--to=wangqing7171@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox