From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Andy Shevchenko <andy@kernel.org>,
Peter Tyser <ptyser@xes-inc.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 10/12] gpio: htc-egpio: use new line value setter callbacks
Date: Mon, 07 Apr 2025 09:13:19 +0200 [thread overview]
Message-ID: <20250407-gpiochip-set-rv-gpio-part1-v1-10-78399683ca38@linaro.org> (raw)
In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpio/gpio-htc-egpio.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpio/gpio-htc-egpio.c b/drivers/gpio/gpio-htc-egpio.c
index a40bd56673fe..b1844a676c7c 100644
--- a/drivers/gpio/gpio-htc-egpio.c
+++ b/drivers/gpio/gpio-htc-egpio.c
@@ -170,7 +170,7 @@ static int egpio_direction_input(struct gpio_chip *chip, unsigned offset)
* Output pins
*/
-static void egpio_set(struct gpio_chip *chip, unsigned offset, int value)
+static int egpio_set(struct gpio_chip *chip, unsigned int offset, int value)
{
unsigned long flag;
struct egpio_chip *egpio;
@@ -198,6 +198,8 @@ static void egpio_set(struct gpio_chip *chip, unsigned offset, int value)
egpio->cached_values &= ~(1 << offset);
egpio_writew((egpio->cached_values >> shift) & ei->reg_mask, ei, reg);
spin_unlock_irqrestore(&ei->lock, flag);
+
+ return 0;
}
static int egpio_direction_output(struct gpio_chip *chip,
@@ -206,12 +208,10 @@ static int egpio_direction_output(struct gpio_chip *chip,
struct egpio_chip *egpio;
egpio = gpiochip_get_data(chip);
- if (test_bit(offset, &egpio->is_out)) {
- egpio_set(chip, offset, value);
- return 0;
- } else {
- return -EINVAL;
- }
+ if (test_bit(offset, &egpio->is_out))
+ return egpio_set(chip, offset, value);
+
+ return -EINVAL;
}
static int egpio_get_direction(struct gpio_chip *chip, unsigned offset)
@@ -324,7 +324,7 @@ static int __init egpio_probe(struct platform_device *pdev)
chip->parent = &pdev->dev;
chip->owner = THIS_MODULE;
chip->get = egpio_get;
- chip->set = egpio_set;
+ chip->set_rv = egpio_set;
chip->direction_input = egpio_direction_input;
chip->direction_output = egpio_direction_output;
chip->get_direction = egpio_get_direction;
--
2.45.2
next prev parent reply other threads:[~2025-04-07 7:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 7:13 [PATCH 00/12] gpio: convert more GPIO chips to using new value setters Bartosz Golaszewski
2025-04-07 7:13 ` [PATCH 01/12] gpio: dln2: use new line value setter callbacks Bartosz Golaszewski
2025-04-07 8:50 ` Andy Shevchenko
2025-04-07 7:13 ` [PATCH 02/12] gpio: eic-sprd: " Bartosz Golaszewski
2025-04-07 7:13 ` [PATCH 03/12] gpio: em: " Bartosz Golaszewski
2025-04-07 7:13 ` [PATCH 04/12] gpio: exar: " Bartosz Golaszewski
2025-04-07 8:51 ` Andy Shevchenko
2025-04-07 7:13 ` [PATCH 05/12] gpio: allow building port-mapped GPIO drivers with COMPILE_TEST=y Bartosz Golaszewski
2025-04-07 9:00 ` Andy Shevchenko
2025-04-15 8:30 ` Linus Walleij
2025-04-17 11:57 ` Bartosz Golaszewski
2025-04-07 7:13 ` [PATCH 06/12] gpio: f7188: use new line value setter callbacks Bartosz Golaszewski
2025-04-07 9:02 ` Andy Shevchenko
2025-04-07 7:13 ` [PATCH 07/12] gpio: graniterapids: " Bartosz Golaszewski
2025-04-07 9:02 ` Andy Shevchenko
2025-04-07 7:13 ` [PATCH 08/12] gpio: gw-pld: " Bartosz Golaszewski
2025-04-07 7:13 ` [PATCH 09/12] gpio: htc-egpio: enable building with COMPILE_TEST=y Bartosz Golaszewski
2025-04-15 8:33 ` Linus Walleij
2025-04-07 7:13 ` Bartosz Golaszewski [this message]
2025-04-07 7:13 ` [PATCH 11/12] gpio: ich: " Bartosz Golaszewski
2025-04-07 8:54 ` Andy Shevchenko
2025-04-15 8:30 ` Linus Walleij
2025-04-07 7:13 ` [PATCH 12/12] gpio: ich: use new line value setter callbacks Bartosz Golaszewski
2025-04-07 8:54 ` Andy Shevchenko
2025-04-16 15:56 ` [PATCH 00/12] gpio: convert more GPIO chips to using new value setters Bartosz Golaszewski
2025-04-16 18:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407-gpiochip-set-rv-gpio-part1-v1-10-78399683ca38@linaro.org \
--to=brgl@bgdev.pl \
--cc=andy@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=ptyser@xes-inc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).