From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Weilin Wang <weilin.wang@intel.com>,
James Clark <james.clark@linaro.org>,
Xu Yang <xu.yang_2@nxp.com>,
John Garry <john.g.garry@oracle.com>,
Howard Chu <howardchu95@gmail.com>,
Levi Yun <yeoreum.yun@arm.com>,
Dominique Martinet <asmadeus@codewreck.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 13/16] perf intel-tpebs: Use stats for retirement latency statistics
Date: Sun, 6 Apr 2025 22:00:58 -0700 [thread overview]
Message-ID: <20250407050101.1389825-14-irogers@google.com> (raw)
In-Reply-To: <20250407050101.1389825-1-irogers@google.com>
struct stats provides access to mean, min and max. It also provides
uniformity with statistics code used elsewhere in perf.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/intel-tpebs.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/tools/perf/util/intel-tpebs.c b/tools/perf/util/intel-tpebs.c
index eee105dbd544..f9584b00fb05 100644
--- a/tools/perf/util/intel-tpebs.c
+++ b/tools/perf/util/intel-tpebs.c
@@ -18,6 +18,7 @@
#include "evsel.h"
#include "mutex.h"
#include "session.h"
+#include "stat.h"
#include "tool.h"
#include "cpumap.h"
#include "metricgroup.h"
@@ -42,12 +43,8 @@ struct tpebs_retire_lat {
struct evsel *evsel;
/** @event: Event passed to perf record. */
char *event;
- /* Count of retire_latency values found in sample data */
- size_t count;
- /* Sum of all the retire_latency values in sample data */
- int sum;
- /* Average of retire_latency, val = sum / count */
- double val;
+ /** @stats: Recorded retirement latency stats. */
+ struct stats stats;
/* Has the event been sent to perf record? */
bool started;
};
@@ -145,9 +142,7 @@ static int process_sample_event(const struct perf_tool *tool __maybe_unused,
* latency value will be used. Save the number of samples and the sum of
* retire latency value for each event.
*/
- t->count += 1;
- t->sum += sample->retire_lat;
- t->val = (double) t->sum / t->count;
+ update_stats(&t->stats, sample->retire_lat);
mutex_unlock(tpebs_mtx_get());
return 0;
}
@@ -522,7 +517,7 @@ int evsel__tpebs_read(struct evsel *evsel, int cpu_map_idx, int thread)
return ret;
mutex_lock(tpebs_mtx_get());
}
- val = rint(t->val);
+ val = rint(t->stats.mean);
mutex_unlock(tpebs_mtx_get());
if (old_count) {
--
2.49.0.504.g3bcea36a83-goog
next prev parent reply other threads:[~2025-04-07 5:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 5:00 [PATCH v2 00/16] Intel TPEBS min/max/mean/last support Ian Rogers
2025-04-07 5:00 ` [PATCH v2 01/16] perf intel-tpebs: Cleanup header Ian Rogers
2025-04-07 5:00 ` [PATCH v2 02/16] perf intel-tpebs: Simplify tpebs_cmd Ian Rogers
2025-04-07 5:00 ` [PATCH v2 03/16] perf intel-tpebs: Rename tpebs_start to evsel__tpebs_open Ian Rogers
2025-04-07 5:00 ` [PATCH v2 04/16] perf intel-tpebs: Separate evsel__tpebs_prepare out of evsel__tpebs_open Ian Rogers
2025-04-07 5:00 ` [PATCH v2 05/16] perf intel-tpebs: Move cpumap_buf " Ian Rogers
2025-04-07 5:00 ` [PATCH v2 06/16] perf intel-tpebs: Reduce scope of tpebs_events_size Ian Rogers
2025-04-07 5:00 ` [PATCH v2 07/16] perf intel-tpebs: Inline get_perf_record_args Ian Rogers
2025-04-07 5:00 ` [PATCH v2 08/16] perf intel-tpebs: Ensure events are opened, factor out finding Ian Rogers
2025-04-07 5:00 ` [PATCH v2 09/16] perf intel-tpebs: Refactor tpebs_results list Ian Rogers
2025-04-07 19:33 ` Liang, Kan
2025-04-07 20:03 ` Ian Rogers
2025-04-07 5:00 ` [PATCH v2 10/16] perf intel-tpebs: Add support for updating counts in evsel__tpebs_read Ian Rogers
2025-04-07 19:37 ` Liang, Kan
2025-04-07 20:07 ` Ian Rogers
2025-04-07 5:00 ` [PATCH v2 11/16] perf intel-tpebs: Add mutex for tpebs_results Ian Rogers
2025-04-07 19:49 ` Liang, Kan
2025-04-07 20:10 ` Ian Rogers
2025-04-07 5:00 ` [PATCH v2 12/16] perf intel-tpebs: Don't close record on read Ian Rogers
2025-04-07 5:00 ` Ian Rogers [this message]
2025-04-07 20:39 ` [PATCH v2 13/16] perf intel-tpebs: Use stats for retirement latency statistics kernel test robot
2025-04-07 5:00 ` [PATCH v2 14/16] perf stat: Add mean, min, max and last --tpebs-mode options Ian Rogers
2025-04-07 19:56 ` Liang, Kan
2025-04-07 20:10 ` Ian Rogers
2025-04-07 5:01 ` [PATCH v2 15/16] perf pmu-events: Add retirement latency to JSON events inside of perf Ian Rogers
2025-04-07 5:01 ` [PATCH v2 16/16] perf record: Retirement latency cleanup in evsel__config Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407050101.1389825-14-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=asmadeus@codewreck.org \
--cc=howardchu95@gmail.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=weilin.wang@intel.com \
--cc=xu.yang_2@nxp.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox