Re: [PATCH] HID: appletb-kbd: Use secs_to_jiffies() instead of msecs_to_jiffies()

Aditya Garg
2025-04-08T07:52:56Z

On 07/04/25 1:59 pm, Thorsten Blum wrote:
> Use secs_to_jiffies() instead of msecs_to_jiffies() and avoid scaling
> the module params 'appletb_tb_idle_timeout' and 'appletb_tb_dim_timeout'
> to milliseconds. secs_to_jiffies() expands to simpler code and reduces
> the size of 'hid-appletb-kbd.ko'.
>
> Reformat the code to silence multiple checkpatch warnings.
>
> No functional changes intended.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---

LGTM

Reviewed-by: Aditya Garg <gargaditya08@live.com>
Tested-by: Aditya Garg <gargaditya08@live.com>