From: Nishanth Menon <nm@ti.com>
To: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Cc: <vigneshr@ti.com>, <kristo@kernel.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <vaishnav.a@ti.com>,
<jai.luthra@linux.dev>, <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <imx@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <u-kumar1@ti.com>
Subject: Re: [PATCH 3/5] arm64: dts: ti: k3-j721e-sk: Fix dtbs_check warnings in IMX219 overlay
Date: Mon, 7 Apr 2025 08:45:23 -0500 [thread overview]
Message-ID: <20250407134523.d56rjpydflmkw2ze@privatize> (raw)
In-Reply-To: <20250401114053.229534-4-y-abhilashchandra@ti.com>
$subject - the patch adds description for the supplies for the sensor.
Please fix the description.
On 17:10-20250401, Yemike Abhilash Chandra wrote:
> The device tree bindings mandate three regulator nodes for the IMX219
> sensor: VANA (analog), VDIG (digital core), and VDDL (digital I/O). Add the
> necessary regulator nodes in the device tree overlay and also the device
> tree bindings do not include a clock-names property. Remove the incorrectly
> added clock-names entry to avoid dtbs_check warnings.
>
> Fixes: f767eb918096 ("arm64: dts: ti: k3-j721e-sk: Add overlay for IMX219")
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
> .../dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso | 35 +++++++++++++++++--
> 1 file changed, 33 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> index 47bb5480b5b0..4eb3cffab032 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> @@ -19,6 +19,33 @@ clk_imx219_fixed: imx219-xclk {
> #clock-cells = <0>;
> clock-frequency = <24000000>;
> };
> +
> + reg_2p8v: regulator-2p8v {
> + compatible = "regulator-fixed";
> + regulator-name = "2P8V";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + vin-supply = <&vdd_sd_dv>;
> + regulator-always-on;
> + };
> +
> + reg_1p8v: regulator-1p8v {
> + compatible = "regulator-fixed";
> + regulator-name = "1P8V";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + vin-supply = <&vdd_sd_dv>;
> + regulator-always-on;
> + };
> +
> + reg_1p2v: regulator-1p2v {
> + compatible = "regulator-fixed";
> + regulator-name = "1P2V";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + vin-supply = <&vdd_sd_dv>;
> + regulator-always-on;
> + };
> };
>
> &csi_mux {
> @@ -34,7 +61,9 @@ imx219_0: imx219-0@10 {
> reg = <0x10>;
>
> clocks = <&clk_imx219_fixed>;
> - clock-names = "xclk";
> + VANA-supply = <®_2p8v>;
> + VDIG-supply = <®_1p8v>;
> + VDDL-supply = <®_1p2v>;
>
> port {
> csi2_cam0: endpoint {
> @@ -56,7 +85,9 @@ imx219_1: imx219-1@10 {
> reg = <0x10>;
>
> clocks = <&clk_imx219_fixed>;
> - clock-names = "xclk";
> + VANA-supply = <®_2p8v>;
> + VDIG-supply = <®_1p8v>;
> + VDDL-supply = <®_1p2v>;
>
> port {
> csi2_cam1: endpoint {
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2025-04-07 13:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 11:40 [PATCH 0/5] Fix dtbs_check warnings in CSI overlays Yemike Abhilash Chandra
2025-04-01 11:40 ` [PATCH 1/5] arm64: dts: ti: j721e-sk: Add DT nodes for power regulators Yemike Abhilash Chandra
2025-04-07 13:41 ` Nishanth Menon
2025-04-08 8:45 ` Yemike Abhilash Chandra
2025-04-01 11:40 ` [PATCH 2/5] arm64: dts: ti: am68-sk: Fix power regulator hierarchy Yemike Abhilash Chandra
2025-04-01 11:40 ` [PATCH 3/5] arm64: dts: ti: k3-j721e-sk: Fix dtbs_check warnings in IMX219 overlay Yemike Abhilash Chandra
2025-04-07 13:45 ` Nishanth Menon [this message]
2025-04-08 9:01 ` Yemike Abhilash Chandra
2025-04-08 12:17 ` Nishanth Menon
2025-04-01 11:40 ` [PATCH 4/5] arm64: dts: ti: k3-am62x: Fix a few minor " Yemike Abhilash Chandra
2025-04-01 11:40 ` [PATCH 5/5] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in OV5640 overlay Yemike Abhilash Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407134523.d56rjpydflmkw2ze@privatize \
--to=nm@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=jai.luthra@linux.dev \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
--cc=y-abhilashchandra@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox