From: Jason Gunthorpe <jgg@nvidia.com>
To: Easwar Hariharan <eahariha@linux.microsoft.com>
Cc: Yishai Hadas <yishaih@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] RDMA/mlx5: convert timeouts to secs_to_jiffies()
Date: Mon, 7 Apr 2025 15:06:38 -0300 [thread overview]
Message-ID: <20250407180638.GA1759834@nvidia.com> (raw)
In-Reply-To: <20250219-rdma-secs-to-jiffies-v1-2-b506746561a9@linux.microsoft.com>
On Wed, Feb 19, 2025 at 09:36:40PM +0000, Easwar Hariharan wrote:
> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
> secs_to_jiffies(). As the value here is a multiple of 1000, use
> secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication.
>
> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
> the following Coccinelle rules:
>
> @depends on patch@
> expression E;
> @@
>
> -msecs_to_jiffies(E * 1000)
> +secs_to_jiffies(E)
>
> -msecs_to_jiffies(E * MSEC_PER_SEC)
> +secs_to_jiffies(E)
>
> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
> ---
> drivers/infiniband/hw/mlx5/mr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied just this patch, Ye's version of mlx4 is more complete.
Thanks
Jason
next prev parent reply other threads:[~2025-04-07 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 21:36 [PATCH 0/2] rdma: Converge on using secs_to_jiffies() Easwar Hariharan
2025-02-19 21:36 ` [PATCH 1/2] RDMA/mlx4: convert timeouts to secs_to_jiffies() Easwar Hariharan
2025-02-19 21:36 ` [PATCH 2/2] RDMA/mlx5: " Easwar Hariharan
2025-04-07 18:06 ` Jason Gunthorpe [this message]
2025-02-20 7:07 ` [PATCH 0/2] rdma: Converge on using secs_to_jiffies() Leon Romanovsky
2025-02-20 16:17 ` Easwar Hariharan
2025-02-22 18:13 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407180638.GA1759834@nvidia.com \
--to=jgg@nvidia.com \
--cc=eahariha@linux.microsoft.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox