Re: [PATCH v2 10/12] checkpatch: Deprecate srcu_read_lock_lite() and srcu_read_unlock_lite()

Paul E. McKenney
2025-04-02T14:12:09Z

On Tue, Apr 01, 2025 at 09:49:11PM -0700, Joe Perches wrote:
> On Tue, 2025-04-01 at 21:23 -0700, Paul E. McKenney wrote:
> > On Tue, Apr 01, 2025 at 08:48:44PM -0700, Joe Perches wrote:
> > > On Tue, 2025-04-01 at 07:05 -0700, Paul E. McKenney wrote:
> > > > On Mon, Mar 31, 2025 at 11:53:25PM -0700, Joe Perches wrote:
> > > > > On Mon, 2025-03-31 at 14:03 -0700, Paul E. McKenney wrote:
> > > > > > Uses of srcu_read_lock_lite() and srcu_read_unlock_lite() are better
> > > > > > served by the new srcu_read_lock_fast() and srcu_read_unlock_fast() APIs.
> > > > > > As in srcu_read_lock_lite() and srcu_read_unlock_lite() would never have
> > > > > > happened had I thought a bit harder a few months ago. Therefore, mark
> > > > > > them deprecated.
> > > > >
> > > > > Would it be better to convert the 3 existing instances?
> > > >
> > > > Both are needed. The point of these checkpatch.pl changes is to prevent
> > > > other instances from being added.
> > >
> > > If those are changed, why not remove the prototypes & functions too?
> > > That would stop more instances being added no?
> >
> > Deprecating it for a cycle then removing the prototypes and functions
> > seems a bit more friendly to me.
>
> OK, please remember to push a checkpatch revert or equivalent
> when it's done. Thanks.

Agreed, and at the same time as I remove the prototypes and functions.
I expect that to be during the 6.17 merge window.

Thanx, Paul