From: Judith Mendez <jm@ti.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Josua Mayer <josua@solid-run.com>, Moteen Shah <m-shah@ti.com>
Subject: [PATCH 0/2] Fix V1P8_SIGNAL_ENA and HIGH_SPEED_ENA
Date: Mon, 7 Apr 2025 17:27:00 -0500 [thread overview]
Message-ID: <20250407222702.2199047-1-jm@ti.com> (raw)
For all TI devices, timing was closed For Legacy and HS modes in
half cycle timing, where data is launched on the negative edge of
clock and latched on the following positive edge of clock. The
switch to full cycle timing happens when any of HIGH_SPEED_ENA,
V1P8_SIGNAL_ENA, or UHS_MODE_SELECT is set.
Currently HIGH_SPEED_ENA is set for HS modes and violates timing
requirements for TI devices so add a .set_hs_ena callback in
sdhci_am654 driver so that HIGH_SPEED_ENA is not set for this mode.
There are eMMC boot failures seen with V1P8_SIGNAL_ENA with a
specific Kingston eMMC due to the sequencing when enumerating to
HS200 mode. Since V1P8_SIGNAL_ENA is optional for eMMC, do not
set V1P8_SIGNAL_ENA be default. This fix was previously merged in
the kernel, but was reverted due to the "heuristics for enabling
the quirk"[0]. The new implementation applies the quirk based-off of
bus width, which should not be an issue since there is no internal
LDO for MMC0 8bit wide interface and hence V1P8_SIGNAL_ENA should only
effect timing for MMC0 interface.
[0] https://lore.kernel.org/linux-mmc/20250127-am654-mmc-regression-v2-1-9bb39fb12810@solid-run.com/
Judith Mendez (2):
PENDING: mmc: sdhci*: Add set_hs_ena to sdhci_ops
mmc: sdhci_am654: Add sdhci_am654_start_signal_voltage_switch
drivers/mmc/host/sdhci.c | 55 +++++++++++++++++++++-------------
drivers/mmc/host/sdhci.h | 2 ++
drivers/mmc/host/sdhci_am654.c | 48 +++++++++++++++++++++++++++++
3 files changed, 85 insertions(+), 20 deletions(-)
--
2.49.0
next reply other threads:[~2025-04-07 22:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 22:27 Judith Mendez [this message]
2025-04-07 22:27 ` [PATCH 1/2] PENDING: mmc: sdhci*: Add set_hs_ena to sdhci_ops Judith Mendez
2025-04-09 12:48 ` Ulf Hansson
2025-04-09 17:11 ` Judith Mendez
2025-04-07 22:27 ` [PATCH 2/2] mmc: sdhci_am654: Add sdhci_am654_start_signal_voltage_switch Judith Mendez
2025-04-11 13:03 ` [PATCH 0/2] Fix V1P8_SIGNAL_ENA and HIGH_SPEED_ENA Hiago De Franco
2025-04-11 16:37 ` Judith Mendez
2025-04-11 19:48 ` Hiago De Franco
2025-04-11 21:55 ` Judith Mendez
2025-04-12 13:20 ` Hiago De Franco
2025-04-14 14:31 ` Judith Mendez
2025-04-14 6:51 ` Francesco Dolcini
2025-04-14 14:37 ` Judith Mendez
2025-04-14 14:57 ` Francesco Dolcini
2025-04-14 22:56 ` Judith Mendez
2025-04-16 16:59 ` Judith Mendez
2025-04-16 19:11 ` Adrian Hunter
2025-04-17 12:03 ` Adrian Hunter
2025-04-17 15:05 ` Judith Mendez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407222702.2199047-1-jm@ti.com \
--to=jm@ti.com \
--cc=adrian.hunter@intel.com \
--cc=josua@solid-run.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=m-shah@ti.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox