public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com
Cc: Shuah Khan <skhan@linuxfoundation.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: [PATCH] x86/Kconfig: Fix dependency for X86_DEBUG_FPU
Date: Mon,  7 Apr 2025 17:10:55 -0600	[thread overview]
Message-ID: <20250407231057.328010-1-skhan@linuxfoundation.org> (raw)

Compile fails when X86_DEBUG_FPU is enabled and X86_REQUIRED_FEATURE_FPU is
disabled. Add explicit dependency on X86_REQUIRED_FEATURE_FPU to fix it.

../arch/x86/kernel/fpu/regset.c:411:(.text+0x4cf2f): undefined reference to `fpregs_soft_get'
ld: vmlinux.o: in function `fpregs_set':
../arch/x86/kernel/fpu/regset.c:445:(.text+0x4d0da): undefined reference to `fpregs_soft_set'
ld: vmlinux.o: in function `copy_fpstate_to_sigframe':
../arch/x86/kernel/fpu/signal.c:197:(.text+0x4da98): undefined reference to `fpregs_soft_get'

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
---
6.14 compile worked without X86_REQUIRED_FEATURE_FPU enabled. Might be a
new dependency. Enabling X86_REQUIRED_FEATURE_FPU fixed it for me on my
test system.

 arch/x86/Kconfig.debug | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index c95c3aaadf97..6738de325fe6 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -199,6 +199,7 @@ config DEBUG_IMR_SELFTEST
 
 config X86_DEBUG_FPU
 	bool "Debug the x86 FPU code"
+	depends on X86_REQUIRED_FEATURE_FPU
 	depends on DEBUG_KERNEL
 	default y
 	help
-- 
2.47.2


             reply	other threads:[~2025-04-07 23:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 23:10 Shuah Khan [this message]
2025-04-08  6:54 ` [PATCH] x86/Kconfig: Fix dependency for X86_DEBUG_FPU Ingo Molnar
2025-04-08 16:51   ` Shuah Khan
2025-04-09 21:34     ` Ingo Molnar
2025-04-09 21:41       ` Shuah Khan
2025-04-10  6:31         ` Ingo Molnar
2025-04-10 21:18           ` Shuah Khan
2025-04-13 19:04             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250407231057.328010-1-skhan@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox