From: "Sheetal ." <sheetal@nvidia.com>
To: <broonie@kernel.org>, <lgirdwood@gmail.com>, <perex@perex.cz>,
<tiwai@suse.com>, <linux-sound@vger.kernel.org>
Cc: <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jonathanh@nvidia.com>, <thierry.reding@gmail.com>,
<mkumard@nvidia.com>, <spujar@nvidia.com>,
Sheetal <sheetal@nvidia.com>
Subject: [RFC PATCH v2] ASoC: soc-pcm: Optimize hw_params() BE DAI call
Date: Tue, 8 Apr 2025 08:30:22 +0000 [thread overview]
Message-ID: <20250408083022.3671283-1-sheetal@nvidia.com> (raw)
From: Sheetal <sheetal@nvidia.com>
The hw_params() function for BE DAI was being called multiple times due
to an unnecessary SND_SOC_DPCM_STATE_HW_PARAMS state check.
Remove the redundant state check to ensure hw_params() is called only once
per BE DAI configuration.
Signed-off-by: Sheetal <sheetal@nvidia.com>
---
Changes in v2:
- Update commit message as its not a fix.
- Marked as RFC patch as it requires feedback from other users
perspective as well.
- The patch is being sent separately as other patch is not RFC.
sound/soc/soc-pcm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index d7f6d3a6d312..c73be27c4ecb 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -2123,7 +2123,6 @@ int dpcm_be_dai_hw_params(struct snd_soc_pcm_runtime *fe, int stream)
continue;
if ((be->dpcm[stream].state != SND_SOC_DPCM_STATE_OPEN) &&
- (be->dpcm[stream].state != SND_SOC_DPCM_STATE_HW_PARAMS) &&
(be->dpcm[stream].state != SND_SOC_DPCM_STATE_HW_FREE))
continue;
--
2.17.1
next reply other threads:[~2025-04-08 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 8:30 Sheetal . [this message]
2025-04-08 9:04 ` [RFC PATCH v2] ASoC: soc-pcm: Optimize hw_params() BE DAI call Sheetal .
2025-05-12 12:01 ` Sameer Pujar
2025-05-13 6:15 ` Péter Ujfalusi
2025-05-21 5:25 ` Sheetal .
2025-05-21 8:17 ` Péter Ujfalusi
2025-05-21 11:33 ` Sheetal .
2025-05-13 11:10 ` Péter Ujfalusi
2025-05-23 9:55 ` Pierre-Louis Bossart
2025-05-23 11:01 ` Sheetal .
2025-05-26 16:18 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250408083022.3671283-1-sheetal@nvidia.com \
--to=sheetal@nvidia.com \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox